Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Inferencer/Fitter #57

Open
mstimberg opened this issue Jul 13, 2021 · 0 comments
Open

Refactor Inferencer/Fitter #57

mstimberg opened this issue Jul 13, 2021 · 0 comments
Assignees
Milestone

Comments

@mstimberg
Copy link
Member

Both classes have a lot in common (everything related to the Brian simulation), and should inherit from a common superclass to share the code. Another possible approach would be to put all the shared code in a separate class that neither Fitter nor Inferencer inherits from, and delegate to an object of that class (e.g. everything related to the simulation could be in a BrianSimulator class, and both Fitter and Inferencer would do something like self.brian_simulator = BrianSimulator(...) in their __init__ and then call self.brian_simulator... for all simulation-related tasks.) Actually, there is already a Simulator class (with implementations for runtime and standalone) – maybe some more code could simply move into this class.

@mstimberg mstimberg added this to To do in sbi integration (GSoC 2021) via automation Jul 13, 2021
@mstimberg mstimberg added this to the next_release milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants