Fix efel units #76
Merged
Fix efel units #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of providing a unitless-array to eFEL, we provided a `Quantity` in units 1/volt This did not affect the results (since the scale was correct), but slowed down everything
This could potentially speed up things greatly by requiring fewer initialization calls, but unfortunately eFEL initializes everything for every trace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
calc_eFELfunction divided the trace by mV, but they were already provided as numpy arrays, not as Brian quantities. This meant that instead of removing units, the division added units of 1/volt, making all later indexing into the array more costly. Note that this only affected the performance, not the results.This PR also refactors things a bit as a first step to fixing #57.