Minor fixes #13
Merged
Minor fixes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One not so minor fix concerns the gamma factor, which seemed to have done the correction for rates incorrectly. The line used:
brian2modelfitting/brian2modelfitting/metric.py
Line 71 in 3175648
Which includes the gamma factor in the
2*abs(...), where it should rather look like this:I wonder how our examples worked 馃槃 (I guess we were in a regime where the total error was positive so that the
abs(...)did not come into play -- or maybe this bug simply prevented us from getting better fits?)