Remove lmfit #66
Merged
Remove lmfit #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing callback support
The callback is now directly included in our cost function, since least_squares does not support callbacks
mstimberg
force-pushed
the
remove_lmfit
branch
from
c948fb9
to
39875a7
Compare
Use binary wheels to install dependencies
mstimberg
force-pushed
the
remove_lmfit
branch
from
39875a7
to
9139af6
Compare
eFEL 4 seems to introduce a change in the scaling of some features
It is optional, but used in tests and examples
|
Other methods and loss functions can wait, will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of
lmfitand replace it by a direct call ofscipy.optimize.least_squares. Even thoughlmfitused the same function internally, there is a difference that might affect results or speed of convergence:lmfitused a non-linear transformation of the variables to map [-∞, ∞] to the given range and then calledleast_squareswithout any bounds. The current approach instead uses the bounds feature of theleast_squaresalgorithm itself. The internal algorithm is by default "Trust Region Reflective algorithm" instead of "Levenberg-Marquardt".Needs some additional work to support other methods and other loss functions (e.g. with some robustness against outliers).