Simplify conditions

[charmander]

Not very important, might be counter to the preferred style, but may as well ask?

[brianc]

Hey @charmander I appreciate the thought & effort, but I'm reticent to change any of the if conditions comparing strictly to null and undefined to a more lax double equals falsy check. That can subtly change semantics & behavior that might not be properly covered in tests, and start causing weird unexpected breakages. I think the CBA on this change is pointing towards potentially higher negative impact & cost than the minor stylistic changes.

[charmander]

x == null is different from typical == checks in that it’s exactly the same as x === null || x === undefined, which is why JSHint has an option to allow it specifically. But it is a style choice, so I can take those changes out if you want.

[brianc]

I appreciate the thought here, but I'm gonna close this as it doesn't really add anything specific. There are a lot of open bugs that need my attention & doing logic refactorings is additional overhead I unfortuantely don't have cycles for right now! If you'd like to pop some issues off the list & PR for those that'd be greatly appreciated! Any logic fixed during those w/ supporting test coverage ofcourse is totally fine. 😄