enable IPv6 support when using native bindings #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(By the way, the NON-native bindings work just fine over IPv6.) |
|
nice 👍 |
brianc
added a commit
that referenced
this pull request
Nov 3, 2012
enable IPv6 support when using native bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using native bindings, you cannot connect to an IPv6 server by hostname.
The only reason this happens is because there is a
dns.lookup()hard-coded for IPv4. Node’s default is to look for both IPv4 and IPv6 addresses when doing a DNS lookup. Removing the forced4argument allows Node’s default behavior and fixes the problem.