use NAN for Node 0.8->0.11+ compatibility #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,11 +11,11 @@ test('disconnects', function() { | |||
| helper.pg.connect(config, function(err, client, done) { | |||
| assert.isNull(err); | |||
| client.query("SELECT * FROM NOW()", function(err, result) { | |||
| process.nextTick(function() { | |||
| setTimeout(function() { | |||
There was a problem hiding this comment.
0.11 currently has a GC problem with certain closures that get GCd before they get invoked, hence the setTimeout()
|
/cc #411 |
|
@rvagg thank you mucho. I've been working at an early stage startup recently (using node-postgres! 👏) with very little time to do a big refactor to support the new version of node & have been kinda scared of getting support out for v0.12.x in time. I cannot thank you enough for going through & doing the hard work on this. I'm going to test this out locally and in our staging environments within the next week or two and get it all merged. One question - do you have a link to docs on NAN? I'd like to dig into it a bit more. Thanks again! |
|
👏 |
brianc
added a commit
that referenced
this pull request
Dec 13, 2013
use NAN for Node 0.8->0.11+ compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 0.11 and onwards uses the new V8 which has huge breaking API changes. NAN is designed to make it easy to support V8 and Node across versions 0.8 to 0.11 and onwards without the need for branching macros. NAN is keeping up-to-date as newer versions of Node 0.11 are released and new breaking changes come upstream from V8.
This PR adds NAN support for compiling against the latest Node 0.11; tests all pass. Would be good to get this in npm before the impending 0.12 release.
Let me know if you have any questions.