Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pgpass #482

Merged
merged 4 commits into from
Dec 27, 2013
Merged

Handle pgpass #482

merged 4 commits into from
Dec 27, 2013

Conversation

hoegaarden
Copy link
Contributor

The native client as well as the js client should now read the pgpass file, if no password specified (should follow the same rules as libpq).

fixes #475 and fixes #455

@@ -19,7 +19,8 @@
"main": "./lib",
"dependencies": {
"generic-pool": "2.0.3",
"buffer-writer": "1.0.0"
"buffer-writer": "1.0.0",
"pgpass": "git://github.com/hoegaarden/pgpass"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this up on npm & reference it there? I only want exactly tagged versions from npm in the package.json file for a variety of reasons (security, maintainability, reliability)

@brianc
Copy link
Owner

brianc commented Dec 13, 2013

@hoegaarden thank you! I love how you did the majority of work in a separate module. Makes things much nicer! 👍 If you could just reference the module directly via the package.json file & resolve the merge conflict I'll happily bring this into node-postgres. :)

@brianc
Copy link
Owner

brianc commented Dec 19, 2013

@hoegaarden ping! Anything I can do to help?

@hoegaarden
Copy link
Contributor Author

Hi.
Sorry, I'm just a bit busy right now; but it's on my list ...

@brianc
Copy link
Owner

brianc commented Dec 27, 2013

Thanks @hoegaarden - I understand being busy. I'll try this out now & merge it. Thanks a ton for your hard work. :) 👍

@hoegaarden
Copy link
Contributor Author

If you find any bugs, stuff to improve, ... just let me know!

brianc added a commit that referenced this pull request Dec 27, 2013
@brianc brianc merged commit 32278a5 into brianc:master Dec 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

native client, ~/.pgpass, hostname Does node-postgres honor .pgpass?
2 participants