-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle pgpass #482
Handle pgpass #482
Conversation
@@ -19,7 +19,8 @@ | |||
"main": "./lib", | |||
"dependencies": { | |||
"generic-pool": "2.0.3", | |||
"buffer-writer": "1.0.0" | |||
"buffer-writer": "1.0.0", | |||
"pgpass": "git://github.com/hoegaarden/pgpass" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get this up on npm & reference it there? I only want exactly tagged versions from npm in the package.json file for a variety of reasons (security, maintainability, reliability)
@hoegaarden thank you! I love how you did the majority of work in a separate module. Makes things much nicer! 👍 If you could just reference the module directly via the package.json file & resolve the merge conflict I'll happily bring this into node-postgres. :) |
@hoegaarden ping! Anything I can do to help? |
Hi. |
Thanks @hoegaarden - I understand being busy. I'll try this out now & merge it. Thanks a ton for your hard work. :) 👍 |
If you find any bugs, stuff to improve, ... just let me know! |
The native client as well as the js client should now read the pgpass file, if no password specified (should follow the same rules as libpq).
fixes #475 and fixes #455