Update vulnerable lodash version #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is triggering security failures when using [nodesecurity/nsp](https://github.com/nodesecurity/nsp) and will soon also fail in npm due to built-in nsp support.
|
pinging @danrzeppa |
|
@spion Why are there failing checks? It appears it is very old versions of node that are having issues. Is this something we don't really care about anymore? |
|
I agree, I don't see any reason to support node 0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is triggering security failures when using nodesecurity/nsp and will soon also fail in npm due to built-in nsp support.
Pinging @brianc - seems like this one might be a little urgent (its certainly failing any CI checks that use nsp)