LPS-129759 We shouldn't hardcode /web in the Liferay code #100317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-129759-pr-9885-sender-jorgediaz-lr-ts-1616721791621
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: shuyangzhou#9885 (Took 1
ci:forwardattempt in 1 minute)Console
@jorgediaz-lr
@shuyangzhou
Original pull request comment:
The changes of LPS-127840 added in the PortalImpl.java are hard-coding the "/web" value, see: #99628
But it should be always got from the layout.friendly.url.public.servlet.mapping portal.properties property (see https://github.com/liferay/liferay-portal/blob/02c62c690a8056ad107ac4f79b69cadca07d027c/portal-impl/src/portal.properties#L5113 )
/cc @bakayattila
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c
Sender Branch:
Branch Name: LPS-129759
1 out of 1jobs PASSEDBranch GIT ID: 8d42e96f8f9165015b1a7d05f54d0173c3346afc
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 21 out of 21 jobs passed in 1 hour 59 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c
Upstream Comparison:
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c
Jenkins Build URL: Acceptance Upstream DXP (master) #1676
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 21 jobs PASSED
21 Successful Jobs:
For more details click here.