[TS] LPS-134061 The available locales for a site must be retrieved using LanguageUtil.getAvailableLocales #103152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anguageUtil.getAvailableLocales, the method group.getAvailableLanguageIds returns the locales that are used in the name and description fields
…mpl class as it is getting the wrong locales
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-134061-pr-4859-sender-jorgediaz-lr-ts-1623680083322
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-echo#4859 (Took 1
ci:forwardattempt in 1 minute)Console
@jorgediaz-lr
@liferay-echo
Original pull request comment:
https://issues.liferay.com/browse/LPS-134061
When we retrieve the available locales for a site, we must use LanguageUtil.getAvailableLocales instead of group.getAvailableLanguageIds().
The group.getAvailableLanguageIds() method it seems it is intended for retrieving the locales used in the name and description of the group object for Staging purposes.
I have also applied the same change to the headless API in the SiteResourceImpl class as it is getting the wrong locales, after double checking it in slack: https://liferay.slack.com/archives/C5E1CRLJY/p1623393578079400
/cc @liferay-usm @drewbrokke @pei-jung
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 0b33b620b95299e2c7306cd637927603b89b745d
Sender Branch:
Branch Name: LPS-134061
1 out of 1jobs PASSEDBranch GIT ID: 7993457b4faa347302e40a8f0f9dec3feb90d472
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 10 out of 10 jobs passed
✔️ ci:test:relevant - 23 out of 25 jobs passed in 2 hours 29 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 0b33b620b95299e2c7306cd637927603b89b745d
Upstream Comparison:
Branch GIT ID: 0b33b620b95299e2c7306cd637927603b89b745d
Jenkins Build URL: Acceptance Upstream DXP (master) #1982
ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 22 out of 25 jobs PASSED
3 Failed Jobs:
test-portal-acceptance-pullrequest(master)test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/022 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at 0b33b62:
test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
Job Results:
0 Tests Passed.
1 Test Failed.
test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
2222 Tests Passed.
31 Tests Failed.