LPS-139334 Text Edition Toolbar does not appear when highlighting a text in a table row

[liferay-continuous-integration]

Forwarded from: liferay-frontend#1761 (Took 2 ci:forward attempts in 7 hours 53 minutes)
Console

@markocikos
@liferay-frontend

Original pull request comment:
JIRA: https://issues.liferay.com/browse/LPS-139334

See steps to reproduce in the JIRA ticket.

In this PR, we are:

• Moving table tools handling from balloonToolbars.create API to own plugin. This is because balloonToolbars.create API relies on CSS selectors. To achieve the desired effect, we would need to set higher priority of text node trigger than a td node trigger. I believe this is impossible, as it is impossible to select a text node with a CSS selector.
• Disabling insert button creation within a table
• Disabling text toolbar if there is not a single alphanumeric in selection. Without this, or a similar restriction, text toolbar opens on multiple cell selection.
• Reverting temporary CI test ignore /cc @magjed4289

Sidenote: I noticed during testing that the 'Headers' option in table toolbar does not work. This is not related to this PR, the feature never worked. We can fix this in a separate PR.

I'm flagging @carloslancha and @julien as reviewers. @diegonvs is the most familiar with the task, but he is on PTO.

Before PR:

After PR:

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 1 hour 33 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 52c435261679ed9eb62b7aafb24b0b8d2fe357aa

Upstream Comparison:

Branch GIT ID: 52c435261679ed9eb62b7aafb24b0b8d2fe357aa
Jenkins Build URL: Acceptance Upstream DXP (master) #2812

ci:test:stable - 10 out of 10 jobs PASSED

10 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/portal-license-smoke-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8_stable/0

ci:test:relevant - 24 out of 26 jobs PASSED

2 Failed Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

24 Successful Jobs:

• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/empty-osgi-core-dir-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/empty-temp-dir-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-compile-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8_stable/0
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/patching-tool-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/pmd-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/portal-license-smoke-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/unit-jdk8_stable/0

For more details click here.

---

This pull contains no unique failures.

---

Failures in common with acceptance upstream results at 52c4352:

1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

   Job Results:

   3 Tests Passed.
   2 Tests Failed.

   1. AXIS_VARIABLE=0 #17481

      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

         junit.framework.AssertionFailedError: 
         Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1642097541473.log:
         !SESSION 2022-01-13 18:12:42.215 -----------------------------------------------
         eclipse.buildId=unknown
         java.version=1.8.0_121
         java.vendor=Oracle Corporation
         BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
         !ENTRY com.liferay.site.initializer.extender 4 0 2022-01-13 18:12:42.215
         
         !MESSAGE FrameworkEvent ERROR
         
         !STACK 0
         
         org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [513]
         
         Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
         at org.eclipse.osgi.container.Module.start(Module.java:444)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
         
         at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
         
         at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
         at com.lifer...

      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

         junit.framework.AssertionFailedError:
         
         FrameworkEvent ERROR
         
         org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [513]
         
         Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
         
         at org.eclipse.osgi.container.Module.start(Module.java:444)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
         
         at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
         
         at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
         
         at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
         at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
         
         at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
         
         at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
         
         at java.nio.file.Files.walkFileTree(Files.java:2670)
         
         at java.nio.file.Files.walkFileTree(Files.java:2742)
         
         at com.liferay.portal.log.asser...

Test bundle downloads:

• liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a973954f2c8415bda475a19a92632d3969bb2a5

Sender Branch:

Branch Name: LPS-139334
Branch GIT ID: 8f896226a7a51084e8710bbad6b497bf93fe8867

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

[brianchandotcom]

Merged. Thank you.
View total diff: 70f10aa...7433b63