LPS-155275 Include integration tests for Custom Object Fields #118386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
@brianchandotcom I wasn't aware that we didn't have tests for Custom Object Fields. Just added it and the goal is to increment for its particular cases (that's why I've created a private method for |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-155275-pr-679-sender-gabrielwas-ts-1654222409028
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-objects#679 (Took 1
ci:forwardattempt in 2 minutes)Console
@gabrielwas
@liferay-objects
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 6d39577e9aa4c4147c1db874de255441b483a78c
Sender Branch:
Branch Name: LPS-155275
1 out of 1jobs PASSEDBranch GIT ID: d4973661bc65ad86a52d2810e8c286f82090a55e
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 26 out of 26 jobs passed
✔️ ci:test:relevant - 82 out of 83 jobs passed in 1 hour 17 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 74021cadd4eb1d43aa08d41f17ceed9590d6b7c6
Upstream Comparison:
Branch GIT ID: a9a26454b586eee07c50e9b42f4a1cd1a935c768
Jenkins Build URL: Acceptance Upstream DXP (master) #3352
ci:test:stable - 26 out of 26 jobs PASSED
26 Successful Jobs:
ci:test:relevant - 81 out of 83 jobs PASSED
2 Failed Jobs:
test-portal-acceptance-pullrequest(master)modules-integration-mysql57-jdk8/0/181 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at a9a2645:
junit.framework.AssertionFailedError: Problem {detail=null, status=Bad Request, title=null, type=null} com.liferay.object.exception.ObjectDefinitionStorageTypeException at com.liferay.object.admin.rest.internal.resource.v1_0.ObjectDefinitionResourceImpl.putObjectDefinition(ObjectDefinitionResourceImpl.java:171) at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:179) at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96) at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:201) at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:104) at org.apache.cxf.interceptor.ServiceInvokerInterceptor$1.run(ServiceInvokerInterceptor.java:59) at org.apache.cxf.interceptor.ServiceInvokerInterceptor.handleMessage(ServiceInvokerInterceptor.java:96) at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308) at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121) at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:265) at org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:234) at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:208) at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:160) at org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:225) a...