Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-153687 Add fetchSharingCollaborators to the Info display Context #120921

Conversation

liferay-continuous-integration
Copy link
Collaborator

Forwarded from: liferay-tango#2636 (Took 3 ci:forward attempts in 12 hours 24 minutes)
Console

@liferay-tango

Original pull request comment:

Motivation

As a content marketer, I want to see all my collaborators after sharing an asset, so that I can easily view and manage my collaborators on a specific asset.

Proposed Solution

This solution use the same approach described in liferay-tango#2612.

We have created a sharing_collaborators.jsp that includes the sharing:collaborators taglib, so the sharing collaborators is rendered using a fetch, as we do with the content performance panel.

Also in this PR we have include the new actions for Blogs and FileEntries that create a URL to this new JSP.

How to test it

Until the frontend part is send, no functional tests can be executed.

Integration tests will be sent in another PR.

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7fa932f4cedb7efd94542c0c51422e6a241b536d

Sender Branch:

Branch Name: LPS-153687.Backend
Branch GIT ID: 141c5d56b3e6336162d89c365d753b03928bcf60

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

✔️ ci:test:stable - 27 out of 27 jobs passed

✔️ ci:test:relevant - 48 out of 49 jobs passed in 1 hour 25 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7fa932f4cedb7efd94542c0c51422e6a241b536d

Upstream Comparison:

Branch GIT ID: e9a5492319dcfab370b8c5ae5cf26b79237f8531
Jenkins Build URL: EE Development Acceptance (master) - 3596 - 2022-07-26[05:11:55]

ci:test:stable - 27 out of 27 jobs PASSED
27 Successful Jobs:
ci:test:relevant - 47 out of 49 jobs PASSED
47 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at e9a5492:
  1. central-requirements-jdk8/0/0
    1. com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles
      junit.framework.AssertionFailedError: Redundant dependency detected in modules/apps/static/portal-k8s-agent/portal-k8s-agent-impl/build.gradle expected:<compileOnly group: "com.liferay.portal", name: "com.liferay.portal.impl", version: "default"> but was:<testCompile group: "com.liferay.portal", name: "com.liferay.portal.impl", version: "default">
        at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1509)
        at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
        at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
        at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)
      

@liferay-continuous-integration
Copy link
Collaborator Author

To conserve resources, the PR Tester does not automatically run for forwarded pull requests.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: d786d3d...2776601

@liferay-continuous-integration liferay-continuous-integration deleted the ci-forward-LPS-153687.Backend-pr-2636-sender-liferay-tango-ts-1658909327365 branch August 3, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants