LPS-37266 (and LPS-37281) #12144
Closed
LPS-37266 (and LPS-37281) #12144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sections. HTML and CSS copied directly from the tempalte editor (edit_template_display.jspf and its main.css)
…te with permission-navigation following existing patterns
Code copied from the template editor
…on instead of using prefixes
An added benefit is that the list of portlets here will have the same order as in the Control Panel which will make them easier to find for administrators.
… since they are not there any more
… Control Panel category is wrong
…odel resources This is good for usability since when the user clicks on, for example, "Users and Organizations" he will expect to see all the permissions related to what can be done from the application of the same name in the Control Panel.
…only make sense for Regular Roles
…roles to manage portal-level entities, since they are shown along with the related Control Panel application
… and portlets 1) UserGroup should be associated to the portlet of the same name and not the more generic users admin 2) Teams are managed from site memberships so they should be associated to that portlet 3) Group, Layout and layout related models should no longer be in users admin since orgs don't have direct pages any more 4) Layout and layout related models should be within Site Pages and not within Sites Admin, which are more about the management of sites, not the entities within.
…on" which is organized just like the new UI of the same name.
…ol Panel categories and remove JSP methods that are no longer needed.
… that are not in the control panel or the "Add to Page" action which are in the category hidden and thus can never be added to a page This solves a known source of confusion because users tend to try to make sense of what they see in the UI and in this case it was showing options that just didn't make sense.
…cation" (aka Application that can be added to a page")
This is no longer needed because the portlets are always shown in the right context and it caused confusion because it was not applied to all portlets in the Control Panel.
…n administrator will see the related resources whenever changing the permissions of a portlet
…" so move the code there. Also, since system portlets are being filtered out afterwards, just don't retrieve them.
…Site Roles since the actions for the site are configurable from other places.
…ename as "Applications"
…fter all the UI changes both must be true always. The only case when that wasn't already show is for the PORTAL (90) portlet, but it doesn't have model resources so it doesn't make a difference.
…tion" and its entry as "Users and Organizations"
…ections created just for them Also rename "General" as "Portal"
|
Some tests have FAILED. ❌ |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull contains many commits, but they are all very small and focused.
They are all about LPS-37266 except for one that fixes one bug (LPS-37281) that I found while working on this.