LPS-45739 #17892
Closed
LPS-45739 #17892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thank you. |
|
Hey Nate, I actually prefer the <liferay-ui:message ?I think it's easier to read? |
|
We also have <liferay-ui:message unicode="<%= true %>" that is as good as escaping I think? Not sure... need you to test though. Thx. |
|
Some tests have FAILED. ❌ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya Brian, we'll be sending a second pull that is going to format all of the alt tags from <liferay-ui:message to <%= HtmlUtil.escapeAttribute(LanguageUtil.get... If you prefer this one to contain all of those changes, just let us know, but we figured the pull was large enough already and was a bit beyond the scope of this pull.