LPS-47130 Create an inner class even if I only found one cause currently #18999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkflow status is encountered
…. Use PortalException and provide a more explanatory message instead. Another option would be to create an specific exception for this case.
…or duplicate field values
… refers to the existing user
…t be met (and it hasn't)
I've left this as a separate commit because I'm unsure about whether this is the best solution. Another alternative could be to rename this exceptions to make them more specific and pass the more specific parameters to their constructors.
|
Hey guys, I'm not sure what the status of this LPS is but as I was cherry picking to build a support driven hotfix for it, I noticed on line 5156 of UserLocalServiceImpl that it should probably be 'existingUser' instead of 'user', so just wanted to let you know. |
|
Thanks Bryan, I'll keep that into account. |
|
Brian, since this pull has been stuck for several days, I'll close it and will send it in smaller pieces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.