Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-45084 - Autoextend session for guests, only show notification for logged in users #19762

Closed
wants to merge 11 commits into from

Conversation

JorgeFerrer
Copy link

We may want to run this through @shuyangzou just in case it may have an impact on performance when a guest users leaves a page open in a browser for a long period of time

@brianchandotcom
Copy link
Owner

@shuyangzhou Please see this pull. I think it should be fine.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: d290b07...10a4cb2

@shuyangzhou
Copy link

So that now a guest session never times out?

@JorgeFerrer
Copy link
Author

@shuyangzhou yes, that's why I thought you should look into it.

@shuyangzhou
Copy link

This may actually cause a problem, but it is more like a security problem rather than a performance problem.
Basically it will make a DDoS attack easier. As it used to require all sessions to be active to hold them in memory. Now as long as they are guest session and not logout they will stay in memory, the attackers do not need to keep them active, it will allow the attacker to use few resources to organize a heavy attack.

I think we should run this through security team.

@NorbertKocsis
Copy link

Could you please confirm if this will be the final resolution or not? We would like to know if we can backport and deliver the fix for customers or we should wait.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants