-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-45084 - Autoextend session for guests, only show notification for logged in users #19762
Conversation
This reverts commit 3185733.
This reverts commit 010196d.
This reverts commit 7bd8dc5.
This reverts commit f5c98a1.
…ad of switching to regex" This reverts commit 34bcef4.
This reverts commit 507e484.
This reverts commit 1ad3202.
This reverts commit 44cd52e.
…ide of url() brackets" This reverts commit acbc7ee.
This reverts commit e7a0e76.
@shuyangzhou Please see this pull. I think it should be fine. |
Merged. Thank you. |
So that now a guest session never times out? |
@shuyangzhou yes, that's why I thought you should look into it. |
This may actually cause a problem, but it is more like a security problem rather than a performance problem. I think we should run this through security team. |
Could you please confirm if this will be the final resolution or not? We would like to know if we can backport and deliver the fix for customers or we should wait. Thanks in advance! |
We may want to run this through @shuyangzou just in case it may have an impact on performance when a guest users leaves a page open in a browser for a long period of time