LPS-52170 #23184
Closed
LPS-52170 #23184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowed failed attempt rather than being warned that the account has been locked
|
Merged. Thank you. |
|
Any way to unit/integration test this? |
|
@mikakoivisto @jonathanmccann please send an integration test. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the only viable fix without a major refactor pulling the authentication code out of UserLocalServiceImpl. If you try to throw the UserLockoutException in UserLocalServiceImpl when the lockout happens it will cause the transaction to rollback and thus the lockout is not saved in database allowing the user to try to login again.
CC @jonathanmccann