LPS-53618 Brian: I'm adding configurationPids to these classes because I guess it was an error to leave them without it. If I'm wrong, please remove this commit. #24079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gAdmin's interface full name. This commit is for well behaved classes (those that have a configuration interface and are used from other classes).
…gAdmin's interface full name. This commit is for classes that have a configuration interface but are not correctly? used from other classes (see following commit for users of these interfaces).
…e I guess it was an error to leave them without it. If I'm wrong, please remove this commit.
|
What about WabFactory and VelocityTemplateResourceLoader ? They both still reference pid's that are just packages. Do we need to update those too? Can you fix those and resend? Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.