Lps 59298 #32474
Closed
Lps 59298 #32474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of lock service. It is can be used since jgroups assure that only one coordinator exsits in cluster and new coordinator will be elected when network partitions merging. The old way is not sensitive enough to cluster status and casue more than one node being master at the same time.
…uest, should not depend on cluster nodes staus on local node to decide if it should be sent since staus on local node may be inconsistent with those on others when dealing with network partition.
…ing portal with the changes of cluster master executor.
…only be invoked when "_enabled" is true
…res the fireAndForget, not handleReceivedClusterRequest() itself should care about it.
…s to check it for ClusterNodeStatus, and ClusterNodeStatus is not an exception, that means only a result could possibly be a ClusterNodeStatus, so just call getResult() directly. Remove the throws from signature to make invoker usage easier.
…rializable, to save a cast.
…ing sorting issue?
…ith the string lexicographical comparing issue.
|
@tinatian can you resend on top of tinatian#37 I'd like you to namespace the vars and methods properly. I didn't review every class. See my latest commit. Thx. |
|
Done, please see #32484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.