Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-61464 Fix Facebook Connect Struts impl #33616

Closed
wants to merge 12 commits into from
Closed

LPS-61464 Fix Facebook Connect Struts impl #33616

wants to merge 12 commits into from

Conversation

stian-sigvartsen
Copy link

Hi Brian. This PR is to fix the current Struts impl of Facebook Connect prior to moving it to MVC. @mhan810 has already reviewed it. See stian-sigvartsen/pull/13

stian-sigvartsen and others added 12 commits December 21, 2015 00:35
@stian-sigvartsen
LPS-61464 FacebookConnectImpl uses the wrong OAuth URL to get access …
f8cc8b3 
…tokens
@stian-sigvartsen
LPS-61464 Give FacebookConnectAction a unique public StrutsAction path
a0dc06a
@stian-sigvartsen
LPS-61464 Recreate missing StrutsAction /login/update_account as a MV…
7906c0d 
…CRenderCommand. Required for associating an existing incomplete user with a new Facebook user
@stian-sigvartsen
LPS-61464 Realign with login portlet migration from Struts to MVC
ad189e1
@stian-sigvartsen
LPS-61464 Fix double encoding issue with redirect URL
1e8ccb3
@stian-sigvartsen
LPS-61464 Use redirect URL generated in context at the start of the F…
d711478 
…acebook login process rather than re-generating this at the end
@stian-sigvartsen
LPS-61464 Fix failed logins when integration is setup with require Fa…
4938957 
…cebook account verification
@stian-sigvartsen
LPS-61464 SF
d7eb7c5
LPS-61464 SF
2c00973
LPS-61464 method not used
e6d6c8a
@stian-sigvartsen
LPS-61464 Fix functional issue introduced by SF
7100150
@stian-sigvartsen
LPS-61464 Removed unused variables (also caused PMD test fail)
d4f1c79
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 2 hours 11 minutes 29 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 15128f54586bc2c47d7a350a111f222ba107ced3

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    23 Jobs Passed.
    5 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/1
    Job Results:

    21 Tests Passed.
    4 Tests Failed.

    1. PoshiRunner.test[CPRolesPGBlogs#AddBlogsEntryOrgRole] - Poshi Report - Poshi Summary - Console Output
    2. PoshiRunner.test[CPRolesPGBlogs#AddBlogsEntryRegRole] - Poshi Report - Poshi Summary - Console Output
    3. PoshiRunner.test[CPRolesPGBlogs#AddBlogsEntrySiteRole] - Poshi Report - Poshi Summary - Console Output
    4. ...

    Click here for more failures.

  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/2
    Job Results:

    23 Tests Passed.
    2 Tests Failed.

    1. PoshiRunner.test[CPSitememberships#AssignMembersSiteTeamUser] - Poshi Report - Poshi Summary - Console Output
    2. PoshiRunner.test[CPSitememberships#RemoveMember] - Poshi Report - Poshi Summary - Console Output
  4. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/3
    Build was aborted
  5. test-portal-acceptance-pullrequest-batch(master)/modules-unit
    Job Results:

    1152 Tests Passed.
    1 Test Failed.

    1. SourceFormatterTest.testSourceFormatter

@stian-sigvartsen
Copy link
Author

@brianchandotcom the SF fail is caused by commit 7100150 which is necessary to correct a function issue which SF introduces...

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 78b61c8...e5e26ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stian-sigvartsen @liferay-continuous-integration @brianchandotcom