Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-64513 Search filters are not remembered when there is no result #39036

Closed
wants to merge 3 commits into from
Closed

LPS-64513 Search filters are not remembered when there is no result #39036

wants to merge 3 commits into from

Conversation

arboliveira
Copy link

@arboliveira arboliveira commented Apr 22, 2016 •
edited

Moved DisplayContext classes to correct package ...display.context, as pointed out in #38998 (comment).

Author: @moltam89
Reviewer: @arboliveira

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 59 minutes 12 seconds

Base Branch:

Branch Name: master
Branch GIT ID: d06c92236b0fd2a2f6fa6284b9e7a71334842105

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    56 Jobs Passed.
    4 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk7
    Job Results:

    1258 Tests Passed.
    1 Test Failed.

    1. SourceFormatterTest.testSourceFormatter
  3. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk7
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #4056
      clean-up-java-processes:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
     [echo] Executing :apps:foundation:portal-search:portal-search:baseline on /opt/dev/projects/github/liferay-portal/modules.
     [exec] Using proxy squid.lax.liferay.com:3128.
     [exec] Configuration on demand is an incubating feature.
     [exec] Download http://repository.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.portal.search/3.0.1/com.liferay.portal.search-3.0.1.pom
     [exec] Download http://repository.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.portal.search/3.0.1/com.liferay.portal.search-3.0.1.jar
     [exec] :apps:foundation:portal-search:portal-search:compileJava UP-TO-DATE
     [exec] :apps:foundation:portal-search:portal-search:buildCSS UP-TO-DATE
     [exec] :apps:foundation:portal-search:portal-search:processResources UP-TO-DATE
     [exec] :apps:foundation:portal-search:portal-search:transpileJS SKIPPED
     [exec] :apps:foundation:portal-search:portal-search:configJSModules SKIPPED
     [exec] :apps:foundation:portal-search:portal-search:copyLibs SKIPPED
     [exec] :apps:foundation:portal-search:portal-search:classes UP-TO-DATE
     [exec] :apps:foundation:portal-search:portal-search:jar
     [exec] [No translation found for macro: range;[=,=+)]
     [exec] :apps:foundation:portal-search:portal-search:jar UP-TO-DATE
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:foundation:portal-search:portal-search:baseline'.
     [exec] > Semantic versioning is incorrect
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:foundation:portal-search:portal-search:baseline'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
  4. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk7
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #3244
           [exec]         return getPersistence().findWithDynamicQuery(dynamicQuery);
     [exec]   }
     [exec]  
     [exec]   /**
     [exec] -     * @see com.liferay.portal.kernel.service.persistence.BasePersistence#findWithDynamicQuery(DynamicQuery, int, int)
     [exec] +     * @see BasePersistence#findWithDynamicQuery(DynamicQuery, int, int)
     [exec]    */
     [exec]   public static List findWithDynamicQuery(DynamicQuery dynamicQuery,
     [exec]       int start, int end) {
     [exec] @@ -82,7 +82,7 @@ public class GroupUtil {
     [exec]   }
     [exec]  
     [exec]   /**
     [exec] -     * @see com.liferay.portal.kernel.service.persistence.BasePersistence#findWithDynamicQuery(DynamicQuery, int, int, OrderByComparator)
     [exec] +     * @see BasePersistence#findWithDynamicQuery(DynamicQuery, int, int, OrderByComparator)
     [exec]    */
     [exec]   public static List findWithDynamicQuery(DynamicQuery dynamicQuery,
     [exec]       int start, int end, OrderByComparator orderByComparator) {
     [exec] @@ -92,14 +92,14 @@ public class GroupUtil {
     [exec]   }
     [exec]  
     [exec]   /**
     [exec] -     * @see com.liferay.portal.kernel.service.persistence.BasePersistence#update(com.liferay.portal.kernel.model.BaseModel)
     [exec] +     * @see BasePersistence#update(com.liferay.portal.kernel.model.BaseModel)
     [exec]    */
     [exec]   public static Group update(Group group) {
     [exec]       return getPersistence().update(group);
     [exec]   }
     [exec]  
     [exec]   /**
     [exec] -     * @see com.liferay.portal.kernel.service.persistence.BasePersistence#update(com.liferay.portal.kernel.model.BaseModel, ServiceContext)
     [exec] +     * @see BasePersistence#update(com.liferay.portal.kernel.model.BaseModel, ServiceContext)
     [exec]    */
     [exec]   public static Group update(Group group, ServiceContext serviceContext) {
     [exec]       return getPersistence().update(group, serviceContext);
     [echo] .
     [echo] 
     [echo] Detected build services changes. See above build services log for more
     [echo] information. Make sure to commit in all build services results.
      [get] Getting: http://test-1-20/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/3244//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20160422122055763.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20160422122055763.txt

@arboliveira
Copy link
Author

Test failures are unrelated.
(Source Formatter failure is from a jsp elsewhere)
(Semver baseline failure is strange since this PR makes no changes to portal-search)

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: b17c0e6...6068345

@arboliveira arboliveira deleted the LPS-64513-pull-104-No-results-remember-Sites-facet branch April 22, 2016 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@arboliveira @liferay-continuous-integration @brianchandotcom