Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-69311 Index geolocation fields from DDM and Expando for later display as map markers in search results #46738

Closed
wants to merge 4 commits into from
Closed

LPS-69311 Index geolocation fields from DDM and Expando for later display as map markers in search results #46738

wants to merge 4 commits into from

Conversation

arboliveira
Copy link

@arboliveira arboliveira commented Feb 8, 2017 •
edited

@arboliveira arboliveira mentioned this pull request Feb 8, 2017
Closed
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 2 hours 14 minutes 23 seconds

Base Branch:

Branch Name: master
Branch GIT ID: c3be82bb16f0ecb28a5487963d6c256cffede82f

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    96 Jobs Passed.
    2 Jobs Failed.

         [exec] 200
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20170208212832492
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/json.data
     [echo] curl --output /opt/dev/projects/github/liferay-jenkins-ee/json.data --silent --write-out %{http_code} http://cloud-10-0-0-31/osb-jenkins-web/map/test-1-9/test-portal-acceptance-pullrequest%28master%29/818/test-portal-acceptance-pullrequest-batch%28master%29/functional-upgrade-tomcat80-mariadb100-jdk8/1/start.properties
     [exec] 200
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20170208212832503
[beanshell] ##
[beanshell] ## /tmp/jenkins/test-1-9/test-portal-acceptance-pullrequest(master)/818/test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat80-mariadb100-jdk8/1/start.properties
[beanshell] ##
[beanshell] 
[beanshell] GITHUB_SENDER_BRANCH_SHA=f1b02475f8b7c134e2ae72d068ad75ee607aac1f
[beanshell] JENKINS_GITHUB_SENDER_USERNAME=liferay
[beanshell] DIST_PATH=/test-1-9/test-portal-acceptance-pullrequest(master)/818/dist
[beanshell] JENKINS_GITHUB_ORIGIN_NAME=liferay
[beanshell] JENKINS_GITHUB_SENDER_BRANCH_NAME=master
[beanshell] JENKINS_LOCAL_GIT_BRANCH_CACHED=true
[beanshell] TOP_LEVEL_GITHUB_COMMENT_ID=278458511
[beanshell] GITHUB_PULL_REQUEST_NUMBER=46738
[beanshell] JENKINS_GITHUB_SENDER_BRANCH_SHA=150280b97ba3fef3fe91fe82dcb6e90e9e3bca8d
[beanshell] GITHUB_ORIGIN_NAME=arboliveira
[beanshell] GITHUB_RECEIVER_USERNAME=brianchandotcom
[beanshell] TEST_BATCH_RUN_TYPE=sequential
[beanshell] TOP_LEVEL_JOB_NAME=test-portal-acceptance-pullrequest(master)
[beanshell] GITHUB_UPSTREAM_BRANCH_SHA=c3be82bb16f0ecb28a5487963d6c256cffede82f
[beanshell] EMAIL_LIST=qa-slave-verify-fail@liferay.com
[beanshell] JENKINS_GITHUB_UPSTREAM_BRANCH_SHA=150280b97ba3fef3fe91fe82dcb6e90e9e3bca8d
[beanshell] TOP_LEVEL_MASTER_HOSTNAME=test-1-9
[beanshell] BUILD_DESCRIPTION=brianchandotcom - PR#46738 - Jenkins Report
[beanshell] TOP_LEVEL_BUILD_URL=https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest(master)/818/
[beanshell] TOP_LEVEL_BRANCH_NAME=master-temp-20170208205440480
[beanshell] JENKINS_GITHUB_UPSTREAM_BRANCH_NAME=master
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase160-jdk8
    Job Results:

    5713 Tests Passed.
    4 Tests Failed.

    1. JaxRsComponentRegistrationTest.classMethod
    2. OpenIdCompanySettingsVerifyProcessTest.testVerify
    3. PortalLogAssertorTest.testScanXMLLog
    4. ...

    Click here for more failures.

For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 6f0cc15...30a2bbe

@brianchandotcom
Copy link
Owner

@arboliveira what's the sorting logic of the templates in modules/apps/foundation/portal-search/portal-search-elasticsearch/src/main/resources/META-INF/mappings/liferay-type-mappings.json

I know the languages go at the bottom, but the stuff in between seems ordered chaotically.

lang, string, and then geo?

Thx

@arboliveira
Copy link
Author

@brianchandotcom Search engines will try to match an unknown field name to the "match" wildcard definition, in order of appearance. First template wins, therefore as a rule of thumb suffixes come first:

  1. *_sortable (many of our fields gain a *_sortable sister regardless of original name)
  2. *_geolocation (both ddm and expando share this suffix for geopoint fields)
  3. assetCategoryTitles* (disregard, this artifact is going away soon - sorry about that)
  4. ddm__keyword__* and expando__keyword__* (we use "keyword" meaning non_analyzed hard strings, like ids; not localizable, so they come before locale templates even though it's a prefix)
  5. All locale suffixed templates (self explanatory)
  6. ddm_* and expando_* (all custom fields not keyword or localized become regular analyzed full text fields.)

So precedence means priority, and order matters. I'd add this explanation to the file if JSON allowed comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@arboliveira @liferay-continuous-integration @brianchandotcom @linolaoj