Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-72118 Wordsmith #49107

Closed
wants to merge 17 commits into from
Closed

LPS-72118 Wordsmith #49107

wants to merge 17 commits into from

Conversation

jbalsas
Copy link

@jbalsas jbalsas commented May 22, 2017

No description provided.

dacousalr and others added 17 commits May 22, 2017 11:14
…wnloadMenuItem() method and use target="_blank" to aviod SPA"

This reverts commit a495d4d.
This reverts commit 9c5a4f7.

sdfsdfsdf
… in <liferay-ui:search-container-column-text> tag"

This reverts commit 41310f8.
…ontal-card>" with minimal adaptations to solve conflicts

This reverts commit c003fde.
…link that needs to be excluded from SPA lifecycle."

This reverts commit d00366f.
@pyoo47
Copy link

pyoo47 commented May 22, 2017

Not going to retest this one.

@brianchandotcom
Copy link
Owner

ci:retest

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@jbalsas


However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
Job Results:

0 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=0,label_exp=!master #64040
         [java] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]
         [java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
         [java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]
         [java] /opt/dev/projects/github/liferay-portal/modules/apps/collaboration/wiki/wiki-web/src/main/resources/META-INF/resources/wiki/view.jsp
         [java] /opt/dev/projects/github/liferay-portal/modules/apps/knowledge-base/knowledge-base-web/src/main/resources/META-INF/resources/admin/common/article_attachments.jsp
         [java] /opt/dev/projects/github/liferay-portal/modules/apps/foundation/frontend-taglib/frontend-taglib/src/main/resources/META-INF/resources/card/horizontal_card/page.jsp
         [java] Exception in thread "main" com.liferay.source.formatter.SourceMismatchException: ./modules/apps/collaboration/wiki/wiki-web/src/main/resources/META-INF/resources/wiki/view.jsp expected:&lt;...c:if>
         [java] 	&lt;/div>
         [java] &lt;/div>[]> but was:&lt;...c:if>
         [java] 	&lt;/div>
         [java] &lt;/div>[
         [java] ]>
         [java] 	at com.liferay.source.formatter.BaseSourceProcessor.processFormattedFile(BaseSourceProcessor.java:334)
         [java] 	at com.liferay.source.formatter.BaseSourceProcessor._format(BaseSourceProcessor.java:519)
         [java] 	at com.liferay.source.formatter.BaseSourceProcessor.access$000(BaseSourceProcessor.java:76)
         [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:113)
         [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:108)
         [java] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
         [java] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
         [java] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
         [java] 	at java.lang.Thread.run(Thread.java:745)
         [echo] The following error occurred while executing this line:
         [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:574: Java returned: 1
          [get] Getting: http://test-1-15/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/64040//consoleText
          [get] To: /opt/dev/projects/github/liferay-portal/20170522152746781.txt
       [delete] Deleting: /opt/dev/projects/github/liferay-portal/20170522152746781.txt

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 2 hours 50 minutes 59 seconds 421 ms

Base Branch:

Branch Name: master
Branch GIT ID: bbdd219fe742c5944704f4904d85967dc87df395

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    89 Jobs Passed.
    3 Jobs Failed.

    Downstream jobs FAILED.
  2. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #109236

      Please fix semantic versioning on jbalsas/pr-730

           [exec] 	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:210)
           [exec] 	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:174)
           [exec] 	at org.gradle.launcher.Main.doAction(Main.java:33)
           [exec] 	at org.gradle.launcher.bootstrap.EntryPoint.run(EntryPoint.java:45)
           [exec] 	at org.gradle.launcher.bootstrap.ProcessBootstrap.runNoExit(ProcessBootstrap.java:60)
           [exec] 	at org.gradle.launcher.bootstrap.ProcessBootstrap.run(ProcessBootstrap.java:37)
           [exec] 	at org.gradle.launcher.GradleMain.main(GradleMain.java:23)
           [exec] 	at org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:31)
           [exec] 	at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:108)
           [exec] 	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
           [exec] Caused by: org.gradle.api.GradleException: Semantic versioning is incorrect
           [exec] 	at com.liferay.gradle.plugins.baseline.BaselineTask.baseline(BaselineTask.java:97)
           [exec] 	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
           [exec] 	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)
           [exec] 	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
           [exec] 	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)
           [exec] 	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)
           [exec] 	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)
           [exec] 	... 62 more
           [exec] 
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:baseline
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] [Baseline Warning] Bundle Version Change Recommended: 2.3.0
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:baseline FAILED

  3. test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #64040
           [java] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]
           [java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
           [java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]
           [java] /opt/dev/projects/github/liferay-portal/modules/apps/collaboration/wiki/wiki-web/src/main/resources/META-INF/resources/wiki/view.jsp
           [java] /opt/dev/projects/github/liferay-portal/modules/apps/knowledge-base/knowledge-base-web/src/main/resources/META-INF/resources/admin/common/article_attachments.jsp
           [java] /opt/dev/projects/github/liferay-portal/modules/apps/foundation/frontend-taglib/frontend-taglib/src/main/resources/META-INF/resources/card/horizontal_card/page.jsp
           [java] Exception in thread "main" com.liferay.source.formatter.SourceMismatchException: ./modules/apps/collaboration/wiki/wiki-web/src/main/resources/META-INF/resources/wiki/view.jsp expected:&lt;...c:if>
           [java] 	&lt;/div>
           [java] &lt;/div>[]> but was:&lt;...c:if>
           [java] 	&lt;/div>
           [java] &lt;/div>[
           [java] ]>
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor.processFormattedFile(BaseSourceProcessor.java:334)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor._format(BaseSourceProcessor.java:519)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor.access$000(BaseSourceProcessor.java:76)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:113)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:108)
           [java] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
           [java] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
           [java] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
           [java] 	at java.lang.Thread.run(Thread.java:745)
           [echo] The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:574: Java returned: 1
            [get] Getting: http://test-1-15/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/64040//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20170522152746781.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20170522152746781.txt
For upstream results, click here.

@yuhai
Copy link

yuhai commented May 23, 2017

ci:reopen

@yuhai
Copy link

yuhai commented May 23, 2017

ci:retest

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 1 hour 30 minutes 4 seconds 397 ms

Base Branch:

Branch Name: master
Branch GIT ID: 9ca2f91b0a8b6298ce0009b773cc1c5df2e43719

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    92 Jobs Passed.
    3 Jobs Failed.

    Downstream jobs FAILED.
  2. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #116256

      Please fix semantic versioning on jbalsas/pr-730

           [exec] 
           [exec] BUILD SUCCESSFUL
           [exec] 
           [exec] Total time: 9.889 secs
           [exec] Gradle build finished at 2017-05-23 02:43:07.896.
           [exec] 
           [echo] Executing :apps:foundation:frontend-taglib:frontend-taglib:baseline on /opt/dev/projects/github/liferay-portal/modules.
           [exec] Using proxy squid.lax.liferay.com:3128.
           [exec] Configuration on demand is an incubating feature.
           [exec] Download http://repository.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.frontend.taglib/2.2.0/com.liferay.frontend.taglib-2.2.0.pom
           [exec] Download http://repository.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.frontend.taglib/2.2.0/com.liferay.frontend.taglib-2.2.0.jar
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:compileJava UP-TO-DATE
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:buildCSS UP-TO-DATE
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:processResources
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:downloadNode SKIPPED
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:downloadMetalCli SKIPPED
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:npmInstall
           [exec] Restoring node_modules of project ':apps:foundation:frontend-taglib:frontend-taglib' from /root/.liferay/node-modules-cache/-1750155637
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:transpileJSRunning 'build'...
           [exec] Compiling soy
           [exec] Finished compiling soy
           [exec] Building to format: amd
           [exec] Finished building to format: amd
           [exec] Finished 'build'...
           [exec] 
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:downloadLiferayModuleConfigGenerator SKIPPED
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:configJSModules
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:copyLibs SKIPPED
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:replaceSoyTranslation
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:wrapSoyAlloyTemplate SKIPPED
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:classes
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:jar UP-TO-DATE
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:baseline
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] [Baseline Warning] Bundle Version Change Recommended: 2.3.0
           [exec] :apps:foundation:frontend-taglib:frontend-taglib:baseline FAILED

  3. test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #95205
           [java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
           [java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]
           [java] /opt/dev/projects/github/liferay-portal/modules/apps/knowledge-base/knowledge-base-web/src/main/resources/META-INF/resources/admin/common/article_attachments.jsp
           [java] /opt/dev/projects/github/liferay-portal/modules/apps/foundation/frontend-taglib/frontend-taglib/src/main/resources/META-INF/resources/card/horizontal_card/page.jsp
           [java] /opt/dev/projects/github/liferay-portal/modules/apps/collaboration/wiki/wiki-web/src/main/resources/META-INF/resources/wiki/view.jsp
           [java] Exception in thread "main" com.liferay.source.formatter.SourceMismatchException: ./modules/apps/knowledge-base/knowledge-base-web/src/main/resources/META-INF/resources/admin/common/article_attachments.jsp expected:&lt;...div>
           [java] 	&lt;/div>
           [java] &lt;/c:if>[]> but was:&lt;...div>
           [java] 	&lt;/div>
           [java] &lt;/c:if>[
           [java] ]>
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor.processFormattedFile(BaseSourceProcessor.java:334)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor._format(BaseSourceProcessor.java:519)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor.access$000(BaseSourceProcessor.java:76)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:113)
           [java] 	at com.liferay.source.formatter.BaseSourceProcessor$1.call(BaseSourceProcessor.java:108)
           [java] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
           [java] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
           [java] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
           [java] 	at java.lang.Thread.run(Thread.java:745)
           [echo] The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:574: Java returned: 1
            [get] Getting: http://test-1-6/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/95205//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20170522193559205.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20170522193559205.txt
For upstream results, click here.

@jpince
Copy link
Collaborator

jpince commented May 23, 2017

@yuhai @jbalsas the semver issue is real, please resolve.

     [exec] :apps:foundation:frontend-taglib:frontend-taglib:baseline
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] [Baseline Warning] Bundle Version Change Recommended: 2.3.0

Closing this pull.

@jpince
Copy link
Collaborator

jpince commented May 23, 2017

ci:close

@jpince
Copy link
Collaborator

jpince commented May 23, 2017

@hhuijser SF failures above are not consistent, SF looks like it's asking for a newline at the end of the file, but it's a different file in each run (and I'm pretty sure we don't put a newline at the end of the file). Can you please take a look at this?

@jbalsas
Copy link
Author

jbalsas commented May 23, 2017

Thanks @jpince, I thought we had avoided those... @dacousalr, can you double check?

@hhuijser
Copy link

@jpince is this the only pull we are having this issue?

@hhuijser
Copy link

Just looking at the changed files on this pull and it does like there were a bunch of newlines (accidentally?) added: https://github.com/brianchandotcom/liferay-portal/pull/49107/files

@jpince
Copy link
Collaborator

jpince commented May 25, 2017

oh, maybe it fails on a different file because that's what it finds first. I do see the newlines that were, as you said, probably unintentionally added. Thanks!

@hhuijser
Copy link

@jpince, correct. When SF throws a SourceMismatchException, we only show the first file that had issues. (so we don't clutter the log when we have lots of violations). Since SF uses threading, the order of files being processed by SF is inconsistent.

@jbalsas jbalsas deleted the pr-730 branch August 3, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants