New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-72118 Wordsmith #49107
LPS-72118 Wordsmith #49107
Conversation
This reverts commit 6749ede.
…wnloadMenuItem() method and use target="_blank" to aviod SPA" This reverts commit a495d4d.
This reverts commit f638e7b.
This reverts commit 9c5a4f7. sdfsdfsdf
This reverts commit 64c0630.
This reverts commit 3685f85.
…ld be "linkData"" This reverts commit 9eacd4d.
…ties" This reverts commit cc935fa.
… in <liferay-ui:search-container-column-text> tag" This reverts commit 41310f8.
…ontal-card>" with minimal adaptations to solve conflicts This reverts commit c003fde.
…n other places" This reverts commit c56b5e2.
This reverts commit d520a40.
…link that needs to be excluded from SPA lifecycle." This reverts commit d00366f.
Not going to retest this one. |
ci:retest |
Pull request test invoked at http://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest(master). |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed: For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8Job Results:0 Tests Passed.
|
ci:reopen |
ci:retest |
Pull request test invoked at http://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest(master). |
ci:close |
@hhuijser SF failures above are not consistent, SF looks like it's asking for a newline at the end of the file, but it's a different file in each run (and I'm pretty sure we don't put a newline at the end of the file). Can you please take a look at this? |
Thanks @jpince, I thought we had avoided those... @dacousalr, can you double check? |
@jpince is this the only pull we are having this issue? |
Just looking at the changed files on this pull and it does like there were a bunch of newlines (accidentally?) added: https://github.com/brianchandotcom/liferay-portal/pull/49107/files |
oh, maybe it fails on a different file because that's what it finds first. I do see the newlines that were, as you said, probably unintentionally added. Thanks! |
@jpince, correct. When SF throws a SourceMismatchException, we only show the first file that had issues. (so we don't clutter the log when we have lots of violations). Since SF uses threading, the order of files being processed by SF is inconsistent. |
No description provided.