Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-59837 Dodge debris left behind by non-Search tests #49304

Closed
wants to merge 1 commit into from
Closed

LPS-59837 Dodge debris left behind by non-Search tests #49304

wants to merge 1 commit into from

Conversation

arboliveira
Copy link

@arboliveira arboliveira commented May 31, 2017 •
edited

This fixes #49274 (comment) and will likely prevent any flakiness of this kind in the future. Sorry about the disturbance but at least adding extra error information paid off. 馃槂 (#49233 (comment)) Search tests will now filter only to groups created by themselves, ignoring leftover documents from tests elsewhere.

@Preston-Crary FYI. Apparently this may not be deleting the uploaded DLFileEntry objects post test:
https://github.com/liferay/liferay-portal/blob/9d29d91d159f6bc65ef15657d7d71560ca267ac7/modules/apps/collaboration/document-library/document-library-test/src/testIntegration/java/com/liferay/document/library/webdav/test/WebDAVLitmusBasicTest.java#L175-L176

@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-16.liferay.com/job/test-portal-acceptance-pullrequest(master).

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@arboliveira

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 2 hours 9 minutes 27 seconds 416 ms

Base Branch:

Branch Name: master
Branch GIT ID: f40b15252709b1fd652d52087b96579c5eaa1fbd

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    94 Jobs Passed.
    2 Jobs Failed.

    Downstream jobs FAILED.
For upstream results, click here.

@arboliveira
Copy link
Author

ci:reopen

@arboliveira
Copy link
Author

ci:retest

@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest(master).

@liferay-continuous-integration
Copy link
Collaborator

All tests PASSED.

Build Time: 1 hour 29 minutes 13 seconds 822 ms

Base Branch:

Branch Name: master
Branch GIT ID: 4b5444373ed2957e1e2d6bbfe0ba7be97424936c

Job Summary:

For more details click here.

@brianchandotcom
Copy link
Owner

@arboliveira can you email the collab team about the doc lib test error? It'd be nice if they fixed the root cause, otherwise, another flaky test will come up. Thx for fixing this.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 2b5a67a...3281322

@arboliveira arboliveira mentioned this pull request Jun 1, 2017
Closed
@arboliveira arboliveira deleted the LPS-59837-AssetTagNamesFacetedSearcherTest-deflake branch October 8, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@arboliveira @liferay-continuous-integration @brianchandotcom