Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "LPS-70904 Treat blank parameter as null" #49309

Closed
wants to merge 1 commit into from
Closed

Revert "LPS-70904 Treat blank parameter as null" #49309

wants to merge 1 commit into from

Conversation

shuyangzhou
Copy link

This reverts commit 61c2428.

@adolfopa I am reverting the change I did in LPS-70904, but for LPS-72571 the root problem is actually inside EditPageMVCActionCommand. When we are done with the action, we should clean up those prp values that are no longer true. prps are supposed to be used for inter portlet communication. But in this case, they are no difference from a standard session attributes, once attached no one is cleaning them up. Leaving them out of date and causing renderring problems. The reason that I am not fixing it for wiki, is because I don't know who else is using prp in this style. It is safer to restore the original behavior, then come back to do proper clean up case by case.

@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest(master).

@adolfopa
Copy link

Thanks a lot @shuyangzhou

@adolfopa adolfopa mentioned this pull request May 31, 2017
Closed
@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@shuyangzhou

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
Job Results:

0 Tests Passed.
1 Test Failed.

  1. AXIS_VARIABLE=0,label_exp=!master #54053
    format-source:
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-kernel/test-classes/unit/system-ext.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/util-java/test-classes/unit/system-ext.properties
     [java] SLF4J: Class path contains multiple SLF4J bindings.
     [java] SLF4J: Found binding in [file:/opt/dev/projects/github/liferay-portal/util-slf4j/classes/org/slf4j/impl/StaticLoggerBinder.class]
     [java] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]
     [java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
     [java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]
     [java] Add the string 'for ' to the previous literal string: ./modules/util/portal-tools-service-builder/src/main/java/com/liferay/portal/tools/service/builder/ServiceBuilder.java 5698
     [java] Exception in thread "main" java.lang.Exception: Add the string 'for ' to the previous literal string: ./modules/util/portal-tools-service-builder/src/main/java/com/liferay/portal/tools/service/builder/ServiceBuilder.java 5698
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:283)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:171)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:574: Java returned: 1
      [get] Getting: http://test-1-21/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/54053//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20170531214132401.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20170531214132401.txt

@shuyangzhou
Copy link
Author

ci:reopen

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 3 hours 14 minutes 56 seconds 265 ms

Base Branch:

Branch Name: master
Branch GIT ID: 3e32cfb3cd5a46bd0fbb1930f538aa8d8995ddca

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    88 Jobs Passed.
    3 Jobs Failed.

    Downstream jobs FAILED.
  2. test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #54053
      format-source:
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/portal-kernel/test-classes/unit/system-ext.properties
     [java] Loading file:/opt/dev/projects/github/liferay-portal/util-java/test-classes/unit/system-ext.properties
     [java] SLF4J: Class path contains multiple SLF4J bindings.
     [java] SLF4J: Found binding in [file:/opt/dev/projects/github/liferay-portal/util-slf4j/classes/org/slf4j/impl/StaticLoggerBinder.class]
     [java] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]
     [java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
     [java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]
     [java] Add the string 'for ' to the previous literal string: ./modules/util/portal-tools-service-builder/src/main/java/com/liferay/portal/tools/service/builder/ServiceBuilder.java 5698
     [java] Exception in thread "main" java.lang.Exception: Add the string 'for ' to the previous literal string: ./modules/util/portal-tools-service-builder/src/main/java/com/liferay/portal/tools/service/builder/ServiceBuilder.java 5698
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:283)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:171)
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:574: Java returned: 1
      [get] Getting: http://test-1-21/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/54053//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20170531214132401.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20170531214132401.txt
For upstream results, click here.

@brianchandotcom
Copy link
Owner

@shuyangzhou I used a new ticket LPS-72860

See d1e4759

@brianchandotcom
Copy link
Owner

@shuyangzhou if we don't use a new ticket, support gets very confused because it says it's fixed but it's actually rolled back. And we can't tell where it was introduced and where it was rolled back.

@shuyangzhou
Copy link
Author

@brianchandotcom ok, got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@shuyangzhou @liferay-continuous-integration @adolfopa @brianchandotcom