Lps 72905 #49375
Closed
Lps 72905 #49375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solution, as the problem no longer exist.
…e Tomcat gets the response writer and close it in the end of the RequestDispatch forward, which makes the header removal logic not working.
…reliable way to remove a response header. We just need to make sure in case of no real output data, we must not output the 20 bytes empty gzip data.
|
Pull request test invoked at http://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest(master). |
|
@tomwang2011 backport is needed for both ee-7.0.x and ee-6.2.x, for ee-6.2.x if it is too complex, ask @tinatian for help. |
|
@tomwang2011 please send backport. I'm not doing it since this one is high risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alee8888 @jpince this is a high risk change which needs special attentions for regressions catching.
And it is a dependent change for another 2 major high risk changes which will eventually fix a customer issue. So please verify this pull asap, so that I can continue the following changes with confidence. Thanks!