Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lps 72911 #49692

Closed
wants to merge 17 commits into from
Closed

Lps 72911 #49692

wants to merge 17 commits into from

Conversation

shuyangzhou
Copy link

No description provided.

tinatian and others added 17 commits June 15, 2017 15:49
@tinatian @shuyangzhou
LPS-72911 Add portal class loader tracker
9c7c5ad
@tinatian @shuyangzhou
LPS-72911 Add integration test
243505a
@tinatian @shuyangzhou
LPS-72911 Add SerializableObjectWrapper, prepare for next
dcd5264
@tinatian @shuyangzhou
LPS-72911 Add support to serialize values set by portlet session
9c28e13
@tinatian @shuyangzhou
LPS-72911 Update packageinfo
81de34a
@tinatian @shuyangzhou
LPS-72911 Fix unit test
6144f81
@shuyangzhou
LPS-72911 Simplify to do a plain BundleActivator
a9bd8f8
@shuyangzhou
LPS-72911 For 3 parts, use String.concat()
cd6cac8
@shuyangzhou
LPS-72911 Use self-bundle
1d75084
@shuyangzhou
LPS-72911 Add test for explicitly resolve the bundle
033eb5a
@shuyangzhou
LPS-72911 Stronger assert
429feac
@shuyangzhou
LPS-72911 Add test for explicitly refresh the bundle
e8e5c21
@shuyangzhou
LPS-72911 Correct log message
57e7607
@shuyangzhou
LPS-72911 Prefer Externalizable in this case to ensure correct method…
32f396b 
… signatures
@shuyangzhou
LPS-72911 SF
0a9b114
@shuyangzhou
LPS-72911 Avoid cast failure, we must allow non-serializable object b…
5f94ef7 
…eing set as session attribute in case session replication is off.
@shuyangzhou
LPS-72911 Fix unit test
192c1ac
@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest(master).

@shuyangzhou shuyangzhou mentioned this pull request Jun 16, 2017
Closed
@shuyangzhou
Copy link
Author

CC @mhan810 @rotty3000

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@shuyangzhou

However, the pull request was closed.

The pull request was closed due to the following integration/unit test failures:

These test failures are a part of a 'module group'/'subrepository' that was changed in this pull request.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

@shuyangzhou
Copy link
Author

ci:reopen

@shuyangzhou
Copy link
Author

@tinatian please update the ticket to state that session replication now needs this new portal property to work properly, so that QA knows how to test it.

And @alee8888 once this ticket passes QA, please communicate it to document team, as customers need to know this.

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 1 hour 22 minutes 10 seconds 158 ms

Base Branch:

Branch Name: master
Branch GIT ID: 10019acea96332af63f5fc7e7b22b5c688c50b45

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    103 Jobs Passed.
    3 Jobs Failed.

    Downstream jobs FAILED.
For upstream results, click here.

@tinatian
Copy link

@shuyangzhou Sure, already updated the ticket.

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: f5c99d1...89e5198

@brianchandotcom
Copy link
Owner

@tinatian merged. Please backport (with my changes in upstream). Thx.

@jorgediaz-lr
Copy link

@tinatian I have backported master code to ee-7.0.x branch but following error is produced:
java.io.InvalidClassException: com.liferay.portal.kernel.io.SerializableObjectWrapper; no valid constructor
more info see: https://issues.liferay.com/browse/LPS-72911?focusedCommentId=1057181&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1057181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@shuyangzhou @liferay-continuous-integration @tinatian @brianchandotcom @jorgediaz-lr