New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-72708 Improve performance upgrade method hasColumn & Unit and integration tests #49928
Conversation
…d to check if a column exists.
…ake sense to keep it. Also not update deprecated classes
…oke the new one from the old one as Mariano did
Pull request test invoked at http://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest(master). |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: @achaparroHowever, the pull request was closed.The pull request was closed due to the following integration/unit test failures: These test failures are a part of a 'module group'/'subrepository' that was changed in this pull request. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase160-jdk8Job Results:6506 Tests Passed.
|
Some tests FAILED.Build Time: 1 hour 34 minutes 8 seconds 99 ms Base Branch:Branch Name: master Job Summary:
For more details click here.Failed Jobs:
For upstream results, click here. |
ci:reopen |
Reopened since the failed tests doesn't seem to be related and it happens in other pulls: |
ci:retest |
Pull request test invoked at http://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest(master). |
Hi @brianchandotcom, Did you have the chance to review this pull? The two failed tests seem not to be related. Thanks. |
Merged. Thank you. |
@achaparro @marianoalvarosaiz @NorbertKocsis please see my changes in upstream. Thx. |
cc @marianoalvarosaiz
cc @NorbertKocsis