Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-75898 Product menu close icon does not display correctly in mobile #53020

Closed
wants to merge 19 commits into from
Closed

LPS-75898 Product menu close icon does not display correctly in mobile #53020

wants to merge 19 commits into from

Conversation

jkappler
Copy link

No description provided.

@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/dynamic-data-l…
5002ed9 
…ists/.gitrepo'.
@hhuijser @liferay-continuous-integration
LPS-69661 Remove legacy property
ea0917e
@hhuijser @liferay-continuous-integration
LPS-74457 Add property 'git.liferay.portal.branch'
187d545
@ealonso @liferay-continuous-integration
LPS-75610 Increase source formatter version
723febb
@ealonso @liferay-continuous-integration
LPS-75610 Use method 'StringBundler.concat'
bc43799
@ealonso @liferay-continuous-integration
LPS-75610 Increase bundle-version
0b058a1
@pavel-savinov @liferay-continuous-integration
LPS-75284 Edit an article on title click instead of preview in accord…
760b7c1 
…ance with new lexicon pattern
@jkappler @liferay-continuous-integration
LPS-75284 Take into account the permissions when clicking and editing…
9d75cbb 
… the articles
@jkappler @liferay-continuous-integration
LPS-75284 Clicking on the feed will redirect the user to the edit screen
d892381
@ealonso @liferay-continuous-integration
LPS-75284 SF
ec19329
@brianchandotcom @liferay-continuous-integration
LPS-74501 if order matters, add a line break
be8def7
@Preston-Crary @liferay-continuous-integration
LPS-75901 Inline only usage of FiniteUniqueStack and FiniteStack. Com…
0eb9c7d 
…bine the two classes.
@shuyangzhou @liferay-continuous-integration
LPS-75901 SF
58b8fed
@shuyangzhou @liferay-continuous-integration
LPS-75901 Not needed anymore
db9f417
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/journal/.gitrepo'.
3bb6632
@liferay-continuous-integration
LPS-0 Clear version-override for modules/apps/web-experience/journal
e6814cc
@marcoscv @jkappler
LPS-75898 - Close btn fix
ff74e96
@marcoscv @jkappler
LPS-75898 - Bootstrap 4 markup upgrade
a4b8315
@jkappler
LPS-75898 SF
8115861
@jkappler jkappler mentioned this pull request Nov 15, 2017
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-19.liferay.com/job/test-portal-acceptance-pullrequest(master).

@jkappler jkappler changed the title LPS-75898 SF LPS-75898 Product menu close icon does not display correctly in mobile Nov 15, 2017
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 3 hours 10 minutes 7 seconds 198 ms

Base Branch:

Branch Name: master
Branch GIT ID: e6814cc8009822a28ab5dda6d4f3c01d648a139c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 465472c4ed2caadde4632fa864b34748e5f18837

119 out of 124 jobs PASSED
119 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    119 Jobs Passed.
    5 Jobs Failed.

    Downstream jobs FAILED.
Failures in common with acceptance upstream results at e6814cc:
  1. test-portal-acceptance-pullrequest-batch(master)/integration-mariadb100-jdk8
    Job Results:

    3745 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=2,label_exp=!master #178444
      1. SQLDateTest.testMillisecondsJDBC
        junit.framework.AssertionFailedError: expected:<1510743122001> but was:<1510743122000>
	at com.liferay.portal.dao.orm.SQLDateTest.testMillisecondsJDBC(SQLDateTest.java:71)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:132)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:127)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl$CallableMethodInvocation.proceed(TransactionInvokerImpl.java:101)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:54)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl.invoke(TransactionInvokerImpl.java:47)
	at com.liferay.portal.kernel.transaction.TransactionInvokerUtil.invoke(TransactionInvokerUtil.java:28)
	at com.liferay.portal.test.rule.TransactionalTestRule$1.evaluate(TransactionalTestRule.java:124)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(Bas...
      2. SQLDateTest.testMillisecondsHibernate
        junit.framework.AssertionFailedError: expected:<1510743122001> but was:<1510743122000>
	at com.liferay.portal.dao.orm.SQLDateTest.testMillisecondsHibernate(SQLDateTest.java:60)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:132)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:127)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl$CallableMethodInvocation.proceed(TransactionInvokerImpl.java:101)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:54)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl.invoke(TransactionInvokerImpl.java:47)
	at com.liferay.portal.kernel.transaction.TransactionInvokerUtil.invoke(TransactionInvokerUtil.java:28)
	at com.liferay.portal.test.rule.TransactionalTestRule$1.evaluate(TransactionalTestRule.java:124)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluat...
  2. test-portal-acceptance-pullrequest-batch(master)/integration-mysql56-jdk8
    Job Results:

    3745 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=2,label_exp=!master #162772
      1. SQLDateTest.testMillisecondsJDBC
        junit.framework.AssertionFailedError: expected:<1510743118001> but was:<1510743118000>
	at com.liferay.portal.dao.orm.SQLDateTest.testMillisecondsJDBC(SQLDateTest.java:71)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:132)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:127)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl$CallableMethodInvocation.proceed(TransactionInvokerImpl.java:101)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:54)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl.invoke(TransactionInvokerImpl.java:47)
	at com.liferay.portal.kernel.transaction.TransactionInvokerUtil.invoke(TransactionInvokerUtil.java:28)
	at com.liferay.portal.test.rule.TransactionalTestRule$1.evaluate(TransactionalTestRule.java:124)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(Bas...
      2. SQLDateTest.testMillisecondsHibernate
        junit.framework.AssertionFailedError: expected:<1510743118001> but was:<1510743118000>
	at com.liferay.portal.dao.orm.SQLDateTest.testMillisecondsHibernate(SQLDateTest.java:60)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:132)
	at com.liferay.portal.test.rule.TransactionalTestRule$1$1.call(TransactionalTestRule.java:127)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl$CallableMethodInvocation.proceed(TransactionInvokerImpl.java:101)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:54)
	at com.liferay.portal.spring.transaction.TransactionInvokerImpl.invoke(TransactionInvokerImpl.java:47)
	at com.liferay.portal.kernel.transaction.TransactionInvokerUtil.invoke(TransactionInvokerUtil.java:28)
	at com.liferay.portal.test.rule.TransactionalTestRule$1.evaluate(TransactionalTestRule.java:124)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
	at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluat...

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 2f393a3...6e3fd5f

@jkappler jkappler deleted the pr-66 branch March 20, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@jkappler @liferay-continuous-integration @brianchandotcom @hhuijser @ealonso @pavel-savinov @Preston-Crary @shuyangzhou @marcoscv