LPS-76354 #53599
Closed
LPS-76354 #53599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s behavior in the back end instead of relying on a disabled checkbox
|
Comment ci:test to trigger CI tests. |
|
/cc @jonathanmccann |
Sent from 
|
@brianchandotcom the initial comment is from Jonathan's original pull. |
|
ci:test |
|
Pull request test invoked at http://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest(master). |
|
ci:test |
|
Pull request test invoked at http://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest(master). |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drewbrokke Sending this through you since it seems more related to Users than Announcements, but let me know if you'd like to have this go elsewhere.
Based off of LPS-216, it seems the Website option should always be checked, however, we're depending on disabled checkboxes to achieve that. Instead, we should enforce this rule in the backend so that it never changes.
I would have liked to remove the entire Website option since I don't see the use for it but that requires a major version increase to portal-kernel which I'd like to avoid.
Let me know if you have any questions.