Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-76935 Updates metal-cli to transpile Object.assign calls for IE11 compatibility #55189

Closed
wants to merge 1 commit into from
Closed

LPS-76935 Updates metal-cli to transpile Object.assign calls for IE11 compatibility #55189

wants to merge 1 commit into from

Conversation

jbalsas
Copy link

@jbalsas jbalsas commented Feb 7, 2018

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jbalsas
Copy link
Author

jbalsas commented Feb 7, 2018

ci:test

@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest(master).

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 2 hours 23 minutes 20 seconds 673 ms

Base Branch:

Branch Name: master
Branch GIT ID: 3a809e743a72957b636b8be785b30af4ed71c245

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: d1c92c85775185bea3b11d011a311d109367745e

118 out of 120 jobs PASSED
118 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at ceb5105:
  1. test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #61103
           [exec] :util:source-formatter:replaceSoyTranslation UP-TO-DATE
     [exec] :util:source-formatter:wrapSoyAlloyTemplate SKIPPED
     [exec] :util:source-formatter:classes
     [exec] :util:source-formatter:jar
     [exec] :util:source-formatter:deploy
     [exec] Files of project ':util:source-formatter' deployed to /opt/dev/projects/github/liferay-portal/tools/sdk/dependencies/com.liferay.source.formatter/lib
     [exec] :util:source-formatter:deployDependencies UP-TO-DATE
     [exec] 
     [exec] BUILD SUCCESSFUL
     [exec] 
     [exec] Total time: 10.779 secs
     [exec] Gradle build finished at 2018-02-07 22:13:03.750.
     [exec] 
     [echo] Running com.liferay.source.formatter.jar 1.0.549.

      format-source-all:
      
[java] Loading file:/opt/dev/projects/github/liferay-portal/portal-impl/classes/system.properties
      
[java] SLF4J: Class path contains multiple SLF4J bindings.
      
[java] SLF4J: Found binding in [file:/opt/dev/projects/github/liferay-portal/util-slf4j/classes/org/slf4j/impl/StaticLoggerBinder.class]
      
[java] SLF4J: Found binding in [jar:file:/opt/dev/projects/github/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]
      
[java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
      
[java] SLF4J: Actual binding is of type [com.liferay.util.sl4fj.LiferayLoggerFactory]
      
[java] /opt/dev/projects/github/liferay-portal/modules/core/portal-compat/blogs/portal-impl-blogs-compat/imported-files.properties (SourceCheck:PropertiesWhitespaceCheck)
      
[java] Line starts with '4' spaces, but '6' spaces are expected: ./modules/core/portal-compat/blogs/portal-impl-blogs-compat/imported-files.properties 3 (SourceCheck:PropertiesWhitespaceCheck)
      
[java] Exception in thread "main" java.lang.Exception: Found 2 formatting issues:
      
[java] 1: Line starts with '4' spaces, but '6' spaces are expected: ./modules/core/portal-compat/blogs/portal-impl-blogs-compat/imported-files.properties 3 (SourceCheck:PropertiesWhitespaceCheck)
      
[java] 2: ./modules/core/portal-compat/blogs/portal-impl-blogs-compat/imported-files.properties expected:<...tal.impl:2.9.0=
      
[java]   [    ]com/liferay/portal/v...> but was:<...tal.impl:2.9.0=
      
[java]   [	]com/liferay/portal/v...>
      
[java]
      
[java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:374)
      
[java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:216)

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 9ed3c5d...25378ce

@jbalsas jbalsas deleted the LPS-76935 branch November 17, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jbalsas @liferay-continuous-integration @brianchandotcom