Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-77432 #55547

Closed
wants to merge 2 commits into from
Closed

LPS-77432 #55547

wants to merge 2 commits into from

Conversation

holatuwol
Copy link

Resend of #55541 that also disables before instantiating the serializers, since it can happen in any order.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@holatuwol
Copy link
Author

ci:test

@liferay-continuous-integration
Copy link
Collaborator

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: dd6530f...d6ede96

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED.

Build Time: 2 hours 30 minutes 21 seconds 661 ms

Base Branch:

Branch Name: master
Branch GIT ID: 020a43262f00b2c7033276a7be92a309ea3ee3e4

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6b6bd056e96d6008ea5745abea6dd3f02b537b45

113 out of 119 jobs PASSED
113 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mariadb100-jdk8
    Job Results:

    8416 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=7,label_exp=!master #64124
      1. UserGroupLocalServiceTest.testDatabaseSearchWithInvalidParamKey
        java.lang.AssertionError: Thread Thread[Framework Event Dispatcher: Equinox Container: c0882430-c116-0018-1dcb-8cc38482b6be,5,main] caught concurrent failure: java.lang.AssertionError: {level=ERROR, loggerName=osgi.logging.com_liferay_portal_security_membership_policy_test, message=FrameworkEvent ERROR 
        java.lang.AssertionError: {level=ERROR, loggerName=osgi.logging.com_liferay_portal_security_membership_policy_test, message=FrameworkEvent ERROR 
        	at com.liferay.portal.test.rule.LogAssertionAppender.append(LogAssertionAppender.java:61)
        	at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
        	at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
        	at org.apache.log4j.Category.callAppenders(Category.java:206)
        	at org.apache.log4j.Category.forcedLog(Category.java:391)
        	at org.apache.log4j.Category.log(Category.java:856)
        	at com.liferay.portal.log.Log4jLogImpl.error(Log4jLogImpl.java:54)
        	at com.liferay.portal.kernel.log.LogWrapper.error(LogWrapper.java:69)
        	at com.liferay.util.sl4fj.LiferayLoggerAdapter.error(LiferayLoggerAdapter.java:110)
        	at com.liferay.portal.equinox.log.bridge.internal.PortalSynchronousLogListener._log(PortalSynchronousLogListener.java:97)
        	at com.liferay.portal.equinox.log.bridge.internal.PortalSynchronousLogListener.logged(PortalSynchronousLogListener.java:76)
        	at org.eclipse.osgi.internal.log.ExtendedLogReaderServiceFactory.safeLogged(ExtendedLogReaderServiceFactory.java:88)
        	at org.ec...

Failures in common with acceptance upstream results at 471479a:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
    Job Results:

    3904 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #197483
      1. PMDTest.testPMDJava
        java.lang.AssertionError: [projects/github/liferay-portal/modules/util/pmd/../../../modules/apps/forms-and-workflow/portal-workflow/portal-workflow-web/src/main/java/com/liferay/portal/workflow/web/internal/portlet/action/UpdateWorkflowDefinitionLinkMVCActionCommand.java:85:	Avoid unused local variables such as 'themeDisplay'.]
        	at org.junit.Assert.fail(Assert.java:88)
        	at org.junit.Assert.assertTrue(Assert.java:41)
        	at com.liferay.pmd.PMDTest.testPMDJava(PMDTest.java:152)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4C...
    2. AXIS_VARIABLE=1,label_exp=!master #197483
      1. PortalWebCompatTest.testNoConflictingImportedFiles
        java.lang.AssertionError: /opt/dev/projects/github/liferay-portal/portal-web/docroot/html/taglib/ui/social_activities should not exist
        	at org.junit.Assert.fail(Assert.java:88)
        	at org.junit.Assert.assertTrue(Assert.java:41)
        	at org.junit.Assert.assertFalse(Assert.java:64)
        	at com.liferay.portal.web.compat.PortalWebCompatTest.testNoConflictingImportedFiles(PortalWebCompatTest.java:69)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        	at org.junit.runners.ParentRu...
  2. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #203152
           [exec] -    build.number=3
           [exec] -    build.date=1428601627829
           [exec] +    build.number=4
           [exec] +    build.date=1519187874472
           [exec]  
           [exec]  ##
           [exec]  ## Spring
           [exec] @@ -26,13 +26,6 @@
           [exec]      # portalContextConfigLocation parameter in web.xml.
           [exec]      #
           [exec]      spring.configs=\
           [exec] -        WEB-INF/classes/META-INF/base-spring.xml,\
           [exec] -        \
           [exec] -        WEB-INF/classes/META-INF/hibernate-spring.xml,\
           [exec] -        WEB-INF/classes/META-INF/infrastructure-spring.xml,\
           [exec] -        \
           [exec] -        WEB-INF/classes/META-INF/cluster-spring.xml,\
           [exec] -        \
           [exec]          WEB-INF/classes/META-INF/portlet-spring.xml,\
           [exec]          \
           [exec]          WEB-INF/classes/META-INF/ext-spring.xml
           [exec] \ No newline at end of file
           [exec] diff --git a/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/lib/tasks-portlet-service.jar b/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/lib/tasks-portlet-service.jar
           [exec] index a686872..2f6376f 100644
           [exec] Binary files a/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/lib/tasks-portlet-service.jar and b/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/lib/tasks-portlet-service.jar differ
           [exec] diff --git a/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/src/service.properties b/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/src/service.properties
           [exec] index 137146c..6505542 100644
           [exec] --- a/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/src/service.properties
           [exec] +++ b/modules/apps/tasks/tasks-portlet/docroot/WEB-INF/src/service.properties
           [exec] @@ -13,8 +13,8 @@
           [exec]  ##
           [exec]  
           [exec]      build.namespace=TMS
           [exec] -    build.number=2
           [exec] -    build.date=1343264478888
           [exec] +    build.number=3
           [exec] +    build.date=1519187904284
           [exec]  
           [exec]  ##
           [exec]  ## Spring
           [echo] .
           [echo] 
           [echo] Detected build services changes. See above build services log for more
           [echo] information. Make sure to commit in all build services results.
            [get] Getting: http://test-1-19/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/203152//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20180221044350888.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20180221044350888.txt
  3. test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #137119
           [java] 			redirectURL);
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public String getEditTemplateBackURL(
           [java] 		LiferayPortletRequest liferayPortletRequest,
           [java] 		LiferayPortletResponse liferayPortletResponse, long classNameId,
           [java] 		long classPK, long resourceClassNameId, String portletResource)
           [java] 		throws Exception {
           [java] 
           [java] 		return _ddmDisplay.getEditTemplateBackURL(
           [java] 			liferayPortletRequest, liferayPortletResponse, classNameId, classPK,
           [java] 			resourceClassNameId, portletResource);
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public String getPortletId() {
           [java] 		return JournalContentPortletKeys.JOURNAL_CONTENT;
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public String getStorageType() {
           [java] 		return _ddmDisplay.getStorageType();
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public String getStructureType() {
           [java] 		return _ddmDisplay.getStructureType();
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public long getTemplateHandlerClassNameId(
           [java] 		DDMTemplate template, long classNameId) {
           [java] 
           [java] 		return _ddmDisplay.getTemplateHandlerClassNameId(template, classNameId);
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public Set<String> getTemplateLanguageTypes() {
           [java] 		return _ddmDisplay.getTemplateLanguageTypes();
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public String getTemplateType() {
           [java] 		return _ddmDisplay.getTemplateType();
           [java] 	}
           [java] 
           [java] 	@Override
           [java] 	public String getViewTemplatesBackURL(
           [java] 		LiferayPortletRequest liferayPortletRequest,
           [java] ]		LiferayPortletResp...>
           [java] 10: ./modules/apps/web-experience/journal/journal-web/src/main/java/com/liferay/journal/web/internal/portlet/action/ExportArticleMVCResourceCommand.java expected:<...ExportArticleHelper([
           [java] 		ExportArticleHelper exportArticleHelper) {
           [java] ]
           [java] 		_exportArticleHel...> but was:<...ExportArticleHelper([ExportArticleHelper exportArticleHelper) {]
           [java] 		_exportArticleHel...>
           [java] 
           [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:374)
           [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:216)

@holatuwol holatuwol deleted the LPS-77432 branch September 21, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants