New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-74615 Upgrade license manager web for current DXP users #55880
Conversation
CI is automatically triggering "ci:test:sf" for this pull to run Source Formatter tests. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
Pull request test invoked at http://test-1-23.liferay.com/job/test-portal-acceptance-pullrequest(master). |
ci:test |
Pull request test invoked at http://test-1-23.liferay.com/job/test-portal-acceptance-pullrequest(master). |
All tests PASSED.Build Time: 16 minutes 50 seconds 596 ms Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 2 Successful Jobs:For more details click here. |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed: For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please re-open this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/functional-smoke-weblogic121-mysql56-jdk8/0Job Results:0 Tests Passed.
|
ci:reopen |
The error doesn't be related |
ci:retest |
Pull request test invoked at http://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest(master). |
@achaparro according to my test, the fix works as expected. |
Merged. Thank you. |
@achaparro see 46979a3 |
Hi @daviddotzhang,
Thank you for your work, it solves the issue. Please, check my modifications since they call to BaseUpgradePortletId to cover all table modifications.
Let me know if everything is ok.
Also, please, backport all the commits related to LPS-74615 once Brian approves this one. I will try to get that this fix is included in the fix pack 40.
Cheers!