LPS-78485 Tests show IndexSettingsContributor does extra fields just as well #56379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering "ci:test:sf" for this pull to run Source Formatter tests. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
Merged. Thx. |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 2 out of 2 jobs passed in 13 minutes 1 second 539 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 2 Successful Jobs:For more details click here. |
arboliveira
deleted the
LPS-78485-Additional-mappings-with-root-type-2-more-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI results: 1 "Failure unique to this pull", a false negative. arboliveira#437 (comment)
This pull request does not change any implementation code. The only change is to one single unit test, which passes. https://github.com/arboliveira/liferay-portal/pull/437/files
cc/ @marco-leo IndexSettingsContributor seems to be already working for the use case you need.
https://issues.liferay.com/browse/LPS-78485