Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-79901 Remove unnecessary verifications in VerifyOrganization #57808

Closed
wants to merge 4 commits into from
Closed

LPS-79901 Remove unnecessary verifications in VerifyOrganization #57808

wants to merge 4 commits into from

Conversation

achaparro
Copy link

@achaparro achaparro commented Apr 30, 2018 •
edited

jonathanmccann and others added 4 commits April 30, 2018 16:15
@jonathanmccann @achaparro
LPS-79901 Remove unnecessary verifications from OrganizationServiceVe…
fbfc5bb 
…rifyProcess added by LPS-2966. No longer necessary since the issue only exists in versions prior to 6.1.
@jonathanmccann @achaparro
LPS-79901 Deprecate unused method
d739dd4
@jonathanmccann @achaparro
LPS-79901 Build service
6cad539
@achaparro
LPS-79901 Keeping rebuildTree method since it's part of the common AP…
49cac02 
…I for those entities organized in herarchy
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" for this pull to run Source Formatter tests.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@achaparro achaparro mentioned this pull request Apr 30, 2018
Closed
@achaparro achaparro changed the title LPS-79901 Keeping rebuildTree method since it's part of the common API for those entities organized in herarchy LPS-79901 Remove unnecessary verifications in VerifyOrganization Apr 30, 2018
@achaparro
Copy link
Author

ci:test

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 2 out of 2 jobs passed in 9 minutes 1 second 469 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 71f665e09db0dac4477808c3da5c183386c9b704

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1db71257a3de5e29441ec5f8c417d1a104b781ac

2 out of 2 jobs PASSED
2 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 104 out of 113 jobs passed in 1 hour 48 minutes 30 seconds 627 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6bb1cde759ce5db278e911bd89e2c8be2f60b03c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1db71257a3de5e29441ec5f8c417d1a104b781ac

104 out of 113 jobs PASSED
104 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 71f665e:
  3. ...

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: ab4a4fa...79ab686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
4 participants
@achaparro @liferay-continuous-integration @brianchandotcom @jonathanmccann