LPS-81229 We don't want to throw an exception here, just notify the user of the error #58746

jkappler · 2018-05-21T07:28:40Z

No description provided.

…ser of the error

liferay-continuous-integration · 2018-05-21T07:28:41Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2018-05-21T07:30:15Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 22 seconds 36 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7c44744478d7996a2683e8eeea2cfc9fc78a8dcf

Sender Branch:

Branch Name: LPS-81229
Branch GIT ID: 3200d0cb548fd5588746018905cf491552a75a51

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2018-05-21T08:10:34Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-acceptance-pullrequest(master)

@jkappler

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

semantic-versioning-jdk8

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #236777

     [exec] :core:portal-compat:message-boards:portal-kernel-message-boards-compat:deploy UP-TO-DATE
     [exec] :core:portal-compat:message-boards:portal-kernel-message-boards-compat:deployDependencies UP-TO-DATE
     [exec] 
     [exec] BUILD SUCCESSFUL
     [exec] 
     [exec] Total time: 7.9 secs
     [exec] Gradle build finished at 2018-05-21 08:09:53.489.
     [exec] 
     [exec] Using proxy squid.lax.liferay.com:3128.
     [exec] Parallel execution with configuration on demand is an incubating feature.
     [exec] Reusing file /opt/dev/projects/github/liferay-portal/modules/core/portal-bootstrap/system.packages.extra.mf.
     [exec] Downloading http://mirrors.lax.liferay.com/cdn.lfrs.sl/repository.liferay.com/nexus/content/repositories/liferay-public-snapshots/com/liferay/org.apache.ivy/2.4.0.LIFERAY-PATCHED-1-SNAPSHOT/org.apache.ivy-2.4.0.LIFERAY-PATCHED-1-SNAPSHOT.jar to /root/.liferay/mirrors/cdn.lfrs.sl/repository.liferay.com/nexus/content/repositories/liferay-public-snapshots/com/liferay/org.apache.ivy/2.4.0.LIFERAY-PATCHED-1-SNAPSHOT/org.apache.ivy-2.4.0.LIFERAY-PATCHED-1-SNAPSHOT.jar.
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * Where:
     [exec] Build file '/opt/dev/projects/github/liferay-portal/modules/build.gradle' line: 75
     [exec] 
     [exec] * What went wrong:
     [exec] A problem occurred configuring project ':apps:frontend-columns-layouttpl:frontend-columns-layouttpl'.
     [exec] > Failed to apply plugin [class 'com.liferay.gradle.plugins.LiferayAntPlugin']
     [exec]    > Could not import Ant build file '/opt/dev/projects/github/liferay-portal/modules/apps/frontend-columns-layouttpl/frontend-columns-layouttpl/build.xml'.
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':apps:frontend-columns-layouttpl:frontend-columns-layouttpl'.
     [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:94)
     [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.doConfigure(LifecycleProjectEvaluator.java:64)
     [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.access$000(LifecycleProjectEvaluator.java:33)

liferay-continuous-integration · 2018-05-21T08:35:12Z

❌ ci:test:relevant - 6 out of 9 jobs passed in 1 hour 6 minutes 14 seconds 18 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7c44744478d7996a2683e8eeea2cfc9fc78a8dcf

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 69ebfb9abf723120a596cf050f6b17f6964f783d

6 out of 9 jobs PASSED

3 Failed Jobs:

6 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #236777

     [exec] :core:portal-compat:message-boards:portal-kernel-message-boards-compat:deploy UP-TO-DATE
     [exec] :core:portal-compat:message-boards:portal-kernel-message-boards-compat:deployDependencies UP-TO-DATE
     [exec] 
     [exec] BUILD SUCCESSFUL
     [exec] 
     [exec] Total time: 7.9 secs
     [exec] Gradle build finished at 2018-05-21 08:09:53.489.
     [exec] 
     [exec] Using proxy squid.lax.liferay.com:3128.
     [exec] Parallel execution with configuration on demand is an incubating feature.
     [exec] Reusing file /opt/dev/projects/github/liferay-portal/modules/core/portal-bootstrap/system.packages.extra.mf.
     [exec] Downloading http://mirrors.lax.liferay.com/cdn.lfrs.sl/repository.liferay.com/nexus/content/repositories/liferay-public-snapshots/com/liferay/org.apache.ivy/2.4.0.LIFERAY-PATCHED-1-SNAPSHOT/org.apache.ivy-2.4.0.LIFERAY-PATCHED-1-SNAPSHOT.jar to /root/.liferay/mirrors/cdn.lfrs.sl/repository.liferay.com/nexus/content/repositories/liferay-public-snapshots/com/liferay/org.apache.ivy/2.4.0.LIFERAY-PATCHED-1-SNAPSHOT/org.apache.ivy-2.4.0.LIFERAY-PATCHED-1-SNAPSHOT.jar.
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * Where:
     [exec] Build file '/opt/dev/projects/github/liferay-portal/modules/build.gradle' line: 75
     [exec] 
     [exec] * What went wrong:
     [exec] A problem occurred configuring project ':apps:frontend-columns-layouttpl:frontend-columns-layouttpl'.
     [exec] > Failed to apply plugin [class 'com.liferay.gradle.plugins.LiferayAntPlugin']
     [exec]    > Could not import Ant build file '/opt/dev/projects/github/liferay-portal/modules/apps/frontend-columns-layouttpl/frontend-columns-layouttpl/build.xml'.
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.ProjectConfigurationException: A problem occurred configuring project ':apps:frontend-columns-layouttpl:frontend-columns-layouttpl'.
     [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.addConfigurationFailure(LifecycleProjectEvaluator.java:94)
     [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.doConfigure(LifecycleProjectEvaluator.java:64)
     [exec] 	at org.gradle.configuration.project.LifecycleProjectEvaluator.access$000(LifecycleProjectEvaluator.java:33)

Failures in common with acceptance upstream results at 7c44744:

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
Job Results:
4 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #236776
  1. PortalLogAssertorTest.testScanXMLLog

jkappler · 2018-05-21T09:03:40Z

ci:reopen

jkappler · 2018-05-21T09:03:59Z

cc:// @jpince

jpince · 2018-05-21T15:08:48Z

ci:close

Sent from GH.

jpince · 2018-05-21T15:08:59Z

pushed upstream liferay@6077b17

Sent from GH.

shuyangzhou · 2018-05-21T16:30:00Z

@jkappler this is not right.
If that exception is meant to be ignored, we should avoid triggering it in the first place. (Unless it is a third party code that we can not control. But it is certainly not the case here.) What this code doing is using exception to do execution flow control, which is the worst way of doing it. Especially this is a model listener, which is at persistence layer, when an exception is triggered, the stack is going to be really deep, this is too heavy.

Please do it in a way to prevent the exception from being created. If you can not get it done soon, this should be reverted and resend later with a complete solution.

LPS-81229 We don't want to throw an exception here, just notify the u…

3200d0c

…ser of the error

liferay-continuous-integration added ci:test - missing ci:test:sf - pending ci:test:relevant - pending ci:test:sf - success and removed ci:test:sf - pending labels May 21, 2018

liferay-continuous-integration closed this May 21, 2018

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels May 21, 2018

liferay-continuous-integration reopened this May 21, 2018

jpince mentioned this pull request May 21, 2018

LPS-80777 Always carry on the cause, otherwise it will be nightmare f… #58734

Closed

liferay-continuous-integration closed this May 21, 2018

anthony-chu mentioned this pull request May 21, 2018

LPS-79566 Generic success messages should not appear embedded jbalsas/liferay-portal#1238

Closed

jkappler deleted the LPS-81229 branch June 3, 2018 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-81229 We don't want to throw an exception here, just notify the user of the error #58746

LPS-81229 We don't want to throw an exception here, just notify the user of the error #58746

jkappler commented May 21, 2018

liferay-continuous-integration commented May 21, 2018

liferay-continuous-integration commented May 21, 2018

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 21, 2018

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8

Job Results:

liferay-continuous-integration commented May 21, 2018

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8

Job Results:

jkappler commented May 21, 2018

jkappler commented May 21, 2018

jpince commented May 21, 2018

jpince commented May 21, 2018

shuyangzhou commented May 21, 2018

LPS-81229 We don't want to throw an exception here, just notify the user of the error #58746

LPS-81229 We don't want to throw an exception here, just notify the user of the error #58746

Conversation

jkappler commented May 21, 2018

liferay-continuous-integration commented May 21, 2018

liferay-continuous-integration commented May 21, 2018

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 22 seconds 36 ms

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented May 21, 2018

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8

Job Results:

liferay-continuous-integration commented May 21, 2018

❌ ci:test:relevant - 6 out of 9 jobs passed in 1 hour 6 minutes 14 seconds 18 ms

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8

Job Results:

jkappler commented May 21, 2018

jkappler commented May 21, 2018

jpince commented May 21, 2018

jpince commented May 21, 2018

shuyangzhou commented May 21, 2018