OAUTH2-135 OAuth2ApplicationScopeAliases scopeAliases column is too short for most usages

[topolik]

Hi Brian,

https://issues.liferay.com/browse/OAUTH2-135

Thanks.

/cc @csierra

[liferay-continuous-integration]

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

[liferay-continuous-integration]

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 313 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 82d5f0c7f86cf643ac63b509f9e72e1f9c9a48f9

Sender Branch:

Branch Name: pull-request-525
Branch GIT ID: ab2b54b4540e2d815b69035723768ef97f509e87

1 out of 1jobs PASSED

1 Successful Jobs:

• test-portal-source-format

For more details click here.

[liferay-continuous-integration]

✔️ ci:test:relevant - 9 out of 9 jobs passed in 1 hour 4 minutes 12 seconds 362 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 82d5f0c7f86cf643ac63b509f9e72e1f9c9a48f9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 5379c2b54bb48aedf61e4f508a4a280de0d96c97

9 out of 9 jobs PASSED

9 Successful Jobs:

• test-portal-acceptance-pullrequest(master)
• test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8
• test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
• test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
• test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8
• test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
• test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
• test-portal-acceptance-pullrequest-dist(master)/dist-jdk8

For more details click here.

[brianchandotcom]

Merged. Thank you.
View total diff: 0f3509a...abc7dd0

[brianchandotcom]

@topolik @csierra this is a very interesting fix/hack. Good job.

Can you send a follow up pull? I don't like using the method "hashCode" to generate the hash.

I'd rather you add a new method, called "predictableHashCode", or "deterministicHashCode" or, "oAuthHashCode", or something else. Why? I think hashCode is JVM dependent. And even if we override it in BaseModel, that implementation may one day change.

And if it changed, our DB logic is now useless.

We need an implementation of hash code that we control, that no one else can change, that is always predictable.

Please send a follow up pull or we'll end up losing data when a server switches JVMs.

[csierra]

Hi Brian,
String.hashcode() is part of String API and is stable across JVM's and versions. It is true that we might risk using hashcode unknowingly for other objects and then it would vary.

Where would you suggest us to add the new function? in the very oauth2-provider-service module?