Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-80662 Minor SF being consistent with gets and fetches #59453

Closed
wants to merge 2 commits into from

Conversation

matethurzo
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 55 seconds 434 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b03ab13527c35748029919379c0b2593371bb759

Sender Branch:

Branch Name: pr-2044
Branch GIT ID: c13ea53d418f51e7fe71303af8ac829192cbd309

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 2 jobs passed in 34 minutes 31 seconds 318 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b03ab13527c35748029919379c0b2593371bb759

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: cc7d07d346a1a27834fba082fe67ddfb097fa513

0 out of 2 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-dist(master)/dist-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=tomcat,label_exp=!master #2443

      Please fix semantic versioning on matethurzo/pr-2044

          [javac] Compiling 106 source files to /opt/dev/projects/github/liferay-portal/util-java/classes
          [javac] Note: Some input files use or override a deprecated API.
          [javac] Note: Recompile with -Xlint:deprecation for details.
          [javac] Note: Some input files use unchecked or unsafe operations.
          [javac] Note: Recompile with -Xlint:unchecked for details.
       [sync-dir] Synchronizing /opt/dev/projects/github/liferay-binaries-cache-2017/.gradle/caches/modules-2/files-2.1 into /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1
       [sync-dir] 0 files synchronized in 244ms
           [exec] Using proxy squid.lax.liferay.com:3128.
           [exec] Download http://repository.liferay.com/nexus/content/groups/public/com/liferay/portal/com.liferay.portal.kernel/2.70.0/com.liferay.portal.kernel-2.70.0.pom
           [exec] Download http://repository.liferay.com/nexus/content/groups/public/com/liferay/portal/com.liferay.portal.kernel/2.70.0/com.liferay.portal.kernel-2.70.0.jar
           [exec] :jar SKIPPED
           [exec] :baseline
           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
           [exec] = ================================================== ========== ========== ========== ========== ==========
           [exec] * com.liferay.blogs.kernel.service                   MAJOR      1.0.1      1.1.0      2.0.0      VERSION INCREASE REQUIRED
           [exec] 	>   class      com.liferay.blogs.kernel.service.BlogsEntryServiceUtil
           [exec] 		-   method     getEntriesPrevAndNext(long)
           [exec] 			-   access     static
           [exec] 			-   return     com.liferay.blogs.kernel.model.BlogsEntry[]
           [exec] 	>   class      com.liferay.blogs.kernel.service.BlogsEntryServiceWrapper
           [exec] 		-   method     getEntriesPrevAndNext(long)
           [exec] 			-   return     com.liferay.blogs.kernel.model.BlogsEntry[]
           [exec] 	>   interface  com.liferay.blogs.kernel.service.BlogsEntryService
           [exec] 		-   method     getEntriesPrevAndNext(long)
           [exec] 			-   access     abstract
           [exec] 			-   annotated  com.liferay.portal.kernel.transaction.Transactional
           [exec] 				-   property   propagation='SUPPORTS'
           [exec] 				-   property   readOnly=true
           [exec] 			-   return     com.liferay.blogs.kernel.model.BlogsEntry[]
           [exec] 	+   version    1.0.1
           [exec] 	-   version    1.1.0
           [exec] Semantic versioning is incorrect

For upstream results, click here.

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants