LPS-81683 SF #59486

jbalsas · 2018-06-01T21:19:48Z

Hey @brianchandotcom, this fixes a variety of related issues, so we ended up collecting them all in a single PR. It includes:

Fix for the x-results-for-x language key we discussed
Fix for clay dropdowns not closing on actions
Fix for navigation bar not working on small viewports
Fix for select layout tag not working properly

I'll take care of resolving the JIRA tickets once it gets merged.

Thanks!

liferay-continuous-integration · 2018-06-01T21:19:49Z

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

liferay-continuous-integration · 2018-06-01T21:23:38Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 4 seconds 100 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 90d6d646625954d790d4692b79edb6bf82ffdf65

Sender Branch:

Branch Name: LPS-81683
Branch GIT ID: a02f769192ba3d6a7edb1e3c192f52b764cd6918

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

brianchandotcom · 2018-06-01T22:24:15Z

@jbalsas rebase error, please resend. Thx.

liferay-continuous-integration · 2018-06-01T22:43:06Z

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

test-portal-acceptance-pullrequest(master)

@jbalsas

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

functional-smoke-tomcat90-mysql57-jdk8/0

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

2 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #88507

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
FrameworkEvent ERROR 
java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to java.lang.String
	at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9134)
	at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9093)
	at com.liferay.registry.internal.ServiceTrackerCustomizerAdapter.removedService(ServiceTrackerCustomizerAdapter.java:51)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:967)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.untrack(AbstractTracked.java:341)
	at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:909)
	at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:917)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:862)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:801)
	a...

PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1527892298706.log: !SESSION 2018-06-01 22:41:54.704 ----------------------------------------------- eclipse.buildId=unknown java.version=1.8.0_121 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

!ENTRY org.eclipse.osgi 4 0 2018-06-01 22:41:54.705 !MESSAGE FrameworkEvent ERROR !STACK 0 java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to java.lang.String at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9134) at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9093) at com.liferay.registry.internal.ServiceTrackerCustomizerAdapter.removedService(ServiceTrackerCustomizerAdapter.java:51) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:967) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1) at org.osgi.util.tracker.AbstractTracked.untrack(AbstractTracked.java:341) at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:909) at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109) at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:917) at org.e...

liferay-continuous-integration · 2018-06-01T23:30:08Z

❌ ci:test:relevant - 8 out of 12 jobs passed in 2 hours 9 minutes 52 seconds 67 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 90d6d646625954d790d4692b79edb6bf82ffdf65

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 00519830e9c36d99d10b47db5888b9c76750c9fb

8 out of 12 jobs PASSED

4 Failed Jobs:

8 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

2 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #88507

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
FrameworkEvent ERROR 
java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to java.lang.String
	at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9134)
	at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9093)
	at com.liferay.registry.internal.ServiceTrackerCustomizerAdapter.removedService(ServiceTrackerCustomizerAdapter.java:51)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:967)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.untrack(AbstractTracked.java:341)
	at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:909)
	at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109)
	at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:917)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:862)
	at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:801)
	a...

PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1527892298706.log: !SESSION 2018-06-01 22:41:54.704 ----------------------------------------------- eclipse.buildId=unknown java.version=1.8.0_121 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

!ENTRY org.eclipse.osgi 4 0 2018-06-01 22:41:54.705 !MESSAGE FrameworkEvent ERROR !STACK 0 java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to java.lang.String at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9134) at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9093) at com.liferay.registry.internal.ServiceTrackerCustomizerAdapter.removedService(ServiceTrackerCustomizerAdapter.java:51) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:967) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1) at org.osgi.util.tracker.AbstractTracked.untrack(AbstractTracked.java:341) at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:909) at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109) at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:917) at org.e...

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

646 Tests Passed.
5 Tests Failed.

AXIS_VARIABLE=0,label_exp=!master #237905

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError:

FrameworkEvent ERROR

java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to java.lang.String

at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9134)

at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9093)

at com.liferay.registry.internal.ServiceTrackerCustomizerAdapter.removedService(ServiceTrackerCustomizerAdapter.java:51)

at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:967)

at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1)

at org.osgi.util.tracker.AbstractTracked.untrack(AbstractTracked.java:341)

at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:909)

at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109)

at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:917)

at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)

at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:148)

at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEventPrivileged(ServiceRegistry.java:862)

at org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.publishServiceEvent(ServiceRegistry.java:801)

a...

PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1527892323300.log: !SESSION 2018-06-01 22:55:30.890 ----------------------------------------------- eclipse.buildId=unknown java.version=1.8.0_121 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

!ENTRY org.eclipse.osgi 4 0 2018-06-01 22:55:30.891 !MESSAGE FrameworkEvent ERROR !STACK 0 java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to java.lang.String at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9134) at com.liferay.portal.util.PortalImpl$CommentsStrutsActionServiceTrackerCustomizer.removedService(PortalImpl.java:9093) at com.liferay.registry.internal.ServiceTrackerCustomizerAdapter.removedService(ServiceTrackerCustomizerAdapter.java:51) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:967) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1) at org.osgi.util.tracker.AbstractTracked.untrack(AbstractTracked.java:341) at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:909) at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109) at org.eclipse.osgi.internal.framework.BundleContextImpl.dispatchEvent(BundleContextImpl.java:917) at org.e...

BootsFacesApplicantPortletTester.runApplicantPortletTest_G_Comments

com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl$1: org.openqa.selenium.TimeoutException: Timed out after 300 seconds waiting for text ('testing 1, 2, 3') to be present in element found by By.xpath: //textarea[contains(@id,':comments')]

at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.createAssertionErrorWithoutExtraInfo(WaitingAsserterImpl.java:43)

at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.assertTrue(WaitingAsserterImpl.java:172)

at com.liferay.faces.test.selenium.browser.internal.WaitingAsserterImpl.assertTextPresentInElement(WaitingAsserterImpl.java:147)

at com.liferay.faces.bridge.test.integration.demo.applicant.BootsFacesApplicantPortletTester.runApplicantPortletTest_G_Comments(BootsFacesApplicantPortletTester.java:51)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)

at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)

at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)

at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)

at org.junit.internal.runners.statements.RunBe...

...

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #190621

Please fix semantic versioning on jbalsas/LPS-81683

[artifact:install] [INFO] Installing /opt/dev/projects/github/liferay-portal/portal-impl/portal-impl-sources.jar to /opt/dev/projects/github/liferay-portal/.m2/com/liferay/portal/com.liferay.portal.impl/3.0.0-SNAPSHOT/com.liferay.portal.impl-3.0.0-SNAPSHOT-sources.jar

[delete] Deleting: /opt/dev/projects/github/liferay-portal/portal-impl/pom.xml

[propertyfile] Updating property file: /opt/dev/projects/github/liferay-portal/.gradle/gradle.properties

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null25044856.properties
download-latest-artifact:
init-compile:
compile:

[copy] Copying 363 files to /opt/dev/projects/github/liferay-portal/portal-kernel/classes
init-jar:
jar:

[sync-dir] Synchronizing /opt/dev/projects/github/liferay-binaries-cache-2017/.gradle/caches/modules-2/files-2.1 into /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1

[sync-dir] 0 files synchronized in 278ms

[exec] Using proxy squid.lax.liferay.com:3128.

[exec] :jar SKIPPED

[exec] :baseline

[exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS

[exec] = ================================================== ========== ========== ========== ========== ==========

[exec] * com.liferay.blogs.kernel.service                   MAJOR      1.0.1      1.1.0      2.0.0      VERSION INCREASE REQUIRED

[exec] 	>   class      com.liferay.blogs.kernel.service.BlogsEntryServiceUtil

[exec] 		-   method     getEntriesPrevAndNext(long)

[exec] 			-   access     static

[exec] 			-   return     com.liferay.blogs.kernel.model.BlogsEntry[]

[exec] 	>   class      com.liferay.blogs.kernel.service.BlogsEntryServiceWrapper

[exec] 		-   method     getEntriesPrevAndNext(long)

[exec] 			-   return     com.liferay.blogs.kernel.model.BlogsEntry[]

[exec] 	>   interface  com.liferay.blogs.kernel.service.BlogsEntryService

[exec] 		-   method     getEntriesPrevAndNext(long)

[exec] 			-   access     abstract

[exec] 			-   annotated  com.liferay.portal.kernel.transaction.Transactional

[exec] 				-   property   propagation='SUPPORTS'

[exec] 				-   property   readOnly=true

[exec] 			-   return     com.liferay.blogs.kernel.model.BlogsEntry[]

[exec] 	+   version    1.0.1

[exec] 	-   version    1.1.0

[exec] Semantic versioning is incorrect

For upstream results, click here.

jbalsas · 2018-06-02T17:37:40Z

Done, see #59514. Thanks!

Carlos Lancha and others added 6 commits June 1, 2018 22:37

LPS-81683 Update Clay to v2.1.6

d8f2103

LPS-81683 Hydrate fronted taglib components

0cadf22

LPS-81681 Add missing key

01430cc

LPS-81781 Hydrate NavigationBarTag

94ecd68

LPS-81815 Hydrates select-layout tag

9c56a19

LPS-81683 SF

a02f769

liferay-continuous-integration added ci:test - missing ci:test:relevant - pending ci:test:sf - pending and removed ci:test:sf - pending labels Jun 1, 2018

brianchandotcom closed this Jun 1, 2018

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Jun 1, 2018

jbalsas deleted the LPS-81683 branch November 17, 2018 13:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-81683 SF #59486

LPS-81683 SF #59486

jbalsas commented Jun 1, 2018 •

edited

liferay-continuous-integration commented Jun 1, 2018

liferay-continuous-integration commented Jun 1, 2018

Base Branch:

Sender Branch:

For more details click here.

brianchandotcom commented Jun 1, 2018

liferay-continuous-integration commented Jun 1, 2018

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Jun 1, 2018

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

For upstream results, click here.

jbalsas commented Jun 2, 2018

LPS-81683 SF #59486

LPS-81683 SF #59486

Conversation

jbalsas commented Jun 1, 2018 • edited

liferay-continuous-integration commented Jun 1, 2018

liferay-continuous-integration commented Jun 1, 2018

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 4 seconds 100 ms

Base Branch:

Sender Branch:

For more details click here.

brianchandotcom commented Jun 1, 2018

liferay-continuous-integration commented Jun 1, 2018

The pull request tester is still running.

However, the pull request was closed.

Critical Failure Details:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Jun 1, 2018

❌ ci:test:relevant - 8 out of 12 jobs passed in 2 hours 9 minutes 52 seconds 67 ms

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8

Job Results:

For upstream results, click here.

jbalsas commented Jun 2, 2018

jbalsas commented Jun 1, 2018 •

edited