Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-81904 Fix it in java class #59661

Closed
wants to merge 4 commits into from

Conversation

sergiogonzalez
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 59 seconds 562 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ee23f7a83788e07520934ebd928a0e697ae81c31

Sender Branch:

Branch Name: pr-4465
Branch GIT ID: 778ac2442396d09250b85f9ab621b805e51e8230

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 6 out of 8 jobs passed in 1 hour 5 minutes 46 seconds 432 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6633d3c296ffd4603bf720481d48dee992b5d61b

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: bc9b276e4c3469cbaf2ef0320f892448ddedc2bd

6 out of 8 jobs PASSED
6 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 6633d3c:
  1. test-portal-acceptance-pullrequest-batch(master)/service-builder-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #87443
           [echo] -		Assert.assertEquals(existingFriendlyURLEntry.getDefaultLanguageId(),
           [echo] -			newFriendlyURLEntry.getDefaultLanguageId());
           [echo]  	}
           [echo]  
           [echo]  	@Test
           [echo] @@ -229,10 +229,10 @@ public class FriendlyURLEntryPersistenceTest {
           [echo]  
           [echo]  	protected OrderByComparator<FriendlyURLEntry> getOrderByComparator() {
           [echo]  		return OrderByComparatorFactoryUtil.create("FriendlyURLEntry",
           [echo] -			"mvccVersion", true, "uuid", true, "friendlyURLEntryId", true,
           [echo] -			"groupId", true, "companyId", true, "createDate", true,
           [echo] -			"modifiedDate", true, "classNameId", true, "classPK", true,
           [echo] -			"defaultLanguageId", true);
           [echo] +			"mvccVersion", true, "uuid", true, "defaultLanguageId", true,
           [echo] +			"friendlyURLEntryId", true, "groupId", true, "companyId", true,
           [echo] +			"createDate", true, "modifiedDate", true, "classNameId", true,
           [echo] +			"classPK", true);
           [echo]  	}
           [echo]  
           [echo]  	@Test
           [echo] @@ -454,6 +454,8 @@ public class FriendlyURLEntryPersistenceTest {
           [echo]  
           [echo]  		friendlyURLEntry.setUuid(RandomTestUtil.randomString());
           [echo]  
           [echo] +		friendlyURLEntry.setDefaultLanguageId(RandomTestUtil.randomString());
           [echo] +
           [echo]  		friendlyURLEntry.setGroupId(RandomTestUtil.nextLong());
           [echo]  
           [echo]  		friendlyURLEntry.setCompanyId(RandomTestUtil.nextLong());
           [echo] @@ -466,8 +468,6 @@ public class FriendlyURLEntryPersistenceTest {
           [echo]  
           [echo]  		friendlyURLEntry.setClassPK(RandomTestUtil.nextLong());
           [echo]  
           [echo] -		friendlyURLEntry.setDefaultLanguageId(RandomTestUtil.randomString());
           [echo] -
           [echo]  		_friendlyURLEntries.add(_persistence.update(friendlyURLEntry));
           [echo]  
           [echo]  		return friendlyURLEntry;
           [echo] .
           [echo] 
           [echo] Detected build services changes. See above build services log for more
           [echo] information. Make sure to commit in all build services results.
            [get] Getting: http://test-1-22/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/87443//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20180605145829805.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20180605145829805.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null130569877.properties

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants