LPS-82527 Unescapes & entities for proper url handling #60396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 56 seconds 782 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-82527-unescape 1 Successful Jobs:For more details click here. |
liferay-continuous-integration
added
ci:test:relevant - success
and removed
ci:test:relevant - pending
labels
|
Merged. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @brianchandotcom, this is a MUST for
7.1. It fixes theRestore from Trashfunctionality in notifications. See full set of tests at jbalsas#1349 (comment).I think this is safe, but I'll reach out to @topolik tomorrow to see how to better handle this general case from a Security point of view.
Thanks!
/cc @ealonso