Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-83063 #60906

Closed
wants to merge 1 commit into from
Closed

LPS-83063 #60906

wants to merge 1 commit into from

Conversation

lionah
Copy link

@lionah lionah commented Jun 29, 2018

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 27 seconds 652 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 733ba3065ea1fe51aa0f68f2eee27ca894c2ee84

Sender Branch:

Branch Name: LPS-83063-UPGRADE-MASTER
Branch GIT ID: 42924673c4621de4627701868cb2fcebd55e44a7

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@lionah
Copy link
Author

lionah commented Jun 29, 2018

Hey Brian,

I actually want to fix this a different way but it might require a new module and a bunch of changes that might be too difficult to test at this stage. The future fix will get away from having the hard coded schema version number.

@brianchandotcom
Copy link
Owner

Merged. Thx.

@lionah lionah deleted the LPS-83063-UPGRADE-MASTER branch July 6, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants