New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-83185 Documents breaking change #61395
Conversation
… right escaping context. This should be done at the very end of the chain.
… right escaping context. This should be done at the very end of the chain.
CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests. Comment "ci:test" to run the full PR Tester for this pull. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 25 seconds 386 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-83185 1 Successful Jobs:For more details click here. |
❌ ci:test:relevant - 0 out of 1 jobs passed in 28 minutes 49 seconds 828 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 1 Failed Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here. |
ci:test |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed: For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/portal-frontend-js-jdk8Job Results:0 Tests Passed.
|
@jbalsas is this a real failure, or a fluke?
|
Looks like a fluke, it's working fine locally 😢 We'll take a look at this again asap! |
ci:reopen |
Merged. Thx. |
@topolik this might be something you care about |
Hey @brianchandotcom!
This change introduces a breaking change as we no longer will escape the portlet description automatically. This was incorrect and causing problems.
I've discussed this with @topolik, who thinks the affected surface is small and with @antonio-ortega who agrees that based on how early in
7.1.x
we are it's preferable to break it before we get any clients in. See backport to7.1.x
-> https://github.com/brianchandotcom/liferay-portal-ee/pull/21058For
7.0.x
, we will send a custom backport if necessary, avoiding the breaking change.Thanks!