Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-84639 Add polyfill for Array.fill method #62313

Closed
wants to merge 3 commits into from
Closed

LPS-84639 Add polyfill for Array.fill method #62313

wants to merge 3 commits into from

Conversation

izaera
Copy link

@izaera izaera commented Aug 21, 2018 •
edited

@brianchandotcom This should be backported to 7.1. I don't know if you are doing automatic backports still... 🤔

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 13 seconds 493 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 52667212dd3813d5e35722e405d200544f225bb4

Sender Branch:

Branch Name: LPS-84639
Branch GIT ID: d0f10c390615caf8a212ece30dbd895326d3a3f8

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:relevant - 19 out of 19 jobs passed in 1 hour 47 minutes 4 seconds 505 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4423c569bafcde93d57ce1c524a73fa20668ffc2

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 47e67c223e38b276e2a57a35edd8ca919bc10204

19 out of 19 jobs PASSED
19 Successful Jobs:
For more details click here.

@izaera
Copy link
Author

izaera commented Aug 21, 2018

ci:test

@brianchandotcom
Copy link
Owner

@izaera backported, I still am for easy stuff like this.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 168 out of 178 jobs passed in 3 hours 13 minutes 19 seconds

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4423c569bafcde93d57ce1c524a73fa20668ffc2

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 47e67c223e38b276e2a57a35edd8ca919bc10204

168 out of 178 jobs PASSED
168 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 4423c56:
  1. test-portal-acceptance-pullrequest-batch(master)/compile-jsp-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #237098
      compile-common-jsp:
   [delete] Deleting directory /opt/dev/projects/github/liferay-portal/portal-web/classes/tomcat
     [echo] Aug 21, 2018 4:23:06 PM org.apache.jasper.servlet.TldScanner scanJars
     [echo] INFO: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time.
     [echo] Aug 21, 2018 4:23:09 PM org.apache.jasper.JspC execute
     [echo] INFO: Compilation completed with [0] errors in [3236] milliseconds
    [javac] Compiling 328 source files to /opt/dev/projects/github/liferay-portal/portal-web/classes/tomcat
    [javac] /opt/dev/projects/github/liferay-portal/portal-web/classes/tomcat/org/apache/jsp/html/taglib/ui/asset_005fadd_005fbutton/page_jsp.java:712: error: reference to getStringValues is ambiguous
    [javac] String[] allAssetTagNames = GetterUtil.getStringValues(request.getAttribute("liferay-ui:asset-add-button:allAssetTagNames"), null);
    [javac]                                       ^
    [javac]   both method getStringValues(Object,String[]) in GetterUtil and method getStringValues(Object,Supplier<String[]>) in GetterUtil match
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-web/build.xml:308: The following error occurred while executing this line:
  2. ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test - failure
Projects
None yet
Milestone
No milestone
4 participants
@izaera @liferay-continuous-integration @brianchandotcom @shuyangzhou