Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-84268 b #62588

Closed
wants to merge 2 commits into from
Closed

LPS-84268 b #62588

wants to merge 2 commits into from

Conversation

stian-sigvartsen
Copy link

LPS-84268

Reviewed stian-sigvartsen/pull/121

"!" and "*" have special meaning based on URI scheme, so should be allowed. We already allow "!".

/cc @topolik

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@stian-sigvartsen stian-sigvartsen mentioned this pull request Aug 30, 2018
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 46 seconds 916 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 117b6ea57fea5686c32c7e082494748f45f1f71b

Sender Branch:

Branch Name: SpencerWoo-LPS-84268b
Branch GIT ID: 936ac6f04fb046ca789ac4935f94a0f74b4ed6c5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 9 out of 20 jobs passed in 55 minutes 4 seconds 185 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 08c77dba2cbe1ba49aa1de2e8945236ab5f96c8c

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0bc6c03b7a032679342dad8b644d704a0eb3434a

9 out of 20 jobs PASSED

11 Failed Jobs:

9 Successful Jobs:
For more details click here.

Failures unique to this pull:

  6. ...

@stian-sigvartsen
Copy link
Author

Tests passed on topolik/pull/601

@brianchandotcom
Copy link
Owner

Merged. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
4 participants
@stian-sigvartsen @liferay-continuous-integration @brianchandotcom @SpencerWoo