Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-84343 Adds tests #63196

Closed
wants to merge 13 commits into from
Closed

LPS-84343 Adds tests #63196

wants to merge 13 commits into from

Conversation

brunobasto
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 39 seconds 205 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ffb720337464d5ceb1fbc19edbf3cbe790713ad8

Sender Branch:

Branch Name: preview_form
Branch GIT ID: 64c33164791adc36db9be649ce764a92c4a2acd8

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

The pull request tester is still running.

Please wait until you get the final report before running 'ci:retest'.

See this link to check on the status of your test:

@brunobasto

However, the pull request was closed.

The pull request was closed because the following critical batches had failed:

For information as to why we automatically close out certain pull requests see this article.

*This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment.

ci:reopen

Critical Failure Details:

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 40 out of 46 jobs passed in 2 hours 44 minutes 39 seconds 136 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ffb720337464d5ceb1fbc19edbf3cbe790713ad8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 44ed7ee678b644201f9a53f8805d537b434b421d

40 out of 46 jobs PASSED
40 Successful Jobs:
For more details click here.

Failures unique to this pull:

For upstream results, click here.

@brunobasto
Copy link
Author

ci:reopen

@brianchandotcom
Copy link
Owner

@brunobasto can you sort:

		if (name.endsWith('translationManager')) {
			component = {
				get: (arg) => 'en_US'
			};
		}
		else if (name.endsWith('settingsDDMForm')) {

Check the name alphabetically.

Please send a follow up pull. Thx!

@brunobasto
Copy link
Author

Sure! Resent here: #63254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
3 participants
@brunobasto @liferay-continuous-integration @brianchandotcom