Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-86440 Forms with page jumps cannot have required fields. Set the enabled property instead of the required one when a field belongs to a jumped page and take the enabled property into account in the field validation #64655

Closed
wants to merge 1 commit into from

Conversation

rafaprax
Copy link

No description provided.

…enabled property instead of the required one when a field belongs to a jumped page and take the enabled property into account in the field validation
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 1 minute 38 seconds 920 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e79a2979a930304c13d59b48ebe943e57050cbe9

Sender Branch:

Branch Name: LPS-86440
Branch GIT ID: eac89e79e910fcea5c69621922632cecdfabbf47

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 22 out of 24 jobs passed in 1 hour 15 minutes 12 seconds 63 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e79a2979a930304c13d59b48ebe943e57050cbe9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 294489cf97e35502549b725030cd74ac7bc26583

22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 209fe1d:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8
    Job Results:

    197 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #250509
      1. ProjectTemplatesTest.testBuildTemplateRest71
        java.lang.AssertionError: [INFO] Error stacktraces are turned on.
        [INFO] Scanning for projects...
        [INFO] 
        [INFO] ------------------------------------------------------------------------
        [INFO] Building Maven Stub Project (No POM) 1
        [INFO] ------------------------------------------------------------------------
        [INFO] 
        [INFO] >>> maven-archetype-plugin:3.0.1:generate (default-cli) > generate-sources @ standalone-pom >>>
        [INFO] 
        [INFO] <<< maven-archetype-plugin:3.0.1:generate (default-cli) < generate-sources @ standalone-pom <<<
        [INFO] 
        [INFO] 
        [INFO] --- maven-archetype-plugin:3.0.1:generate (default-cli) @ standalone-pom ---
        [INFO] Generating project in Batch mode
        [INFO] Archetype repository not defined. Using the one from [com.liferay:com.liferay.project.templates.rest:1.0.9 -> https://repository-cdn.liferay.com/nexus/content/groups/public] found in catalog remote
        [INFO] ----------------------------------------------------------------------------
        [INFO] Using following parameters for creating project from Archetype: com.liferay.project.templates.rest:1.0.18
        [INFO] ----------------------------------------------------------------------------
        [INFO] Parameter: groupId, Value: com.test
        [INFO] Parameter: artifactId, Value: my-rest
        [INFO] Parameter: version, Value: 1.0.0
        [INFO] Parameter: package, Value: my.rest
        [INFO] Parameter: packageInPathFormat, Value: my/rest
        [INFO] Parameter: liferayVersion, Value: 7.1
        [INFO] Parameter: author, Value: root
        [INFO] Parameter: groupId, Val...

@brianchandotcom
Copy link
Owner

Merged. Thx.

@brianchandotcom
Copy link
Owner

@rafaprax see 15c758f

and please backport. Thx.

@rafaprax
Copy link
Author

Thx @brianchandotcom and sorry for my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants