Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-88194 #65846

Closed
wants to merge 15 commits into from
Closed

LPS-88194 #65846

wants to merge 15 commits into from

Conversation

adolfopa
Copy link

No description provided.

@adolfopa
LPS-87864 Add new API to manage selections in D&M
aafcd99
@adolfopa
LPS-87864 Refactor logic to minimize dependencies on type of selection
d95e269 
Ideally, the code shouldn't have to worry about a selection being
single valued, multiple or parent based (this last one not implemented
yet).

The only abstraction leak here is the `isMultiple` method, which we
need for the UI.
@adolfopa
LPS-87864 Change literal so that it can be used in other actions
46322dd
@adolfopa
LPS-87864 Semver
d0ddafe
@adolfopa
LPS-87864 Avoid exception wrapping and type check conditionals
de320d1
@adolfopa
LPS-87864 Use streams API to simplify
b8e43ae
@adolfopa
LPS-87864 Use Collections API
8b580f3
@adolfopa
LPS-87864 No need to copy set
bb162d6 
The commonTagNamesSet is not used after this, so we can avoid copying
it as it can be safely mutated.
@adolfopa
LPS-87864 Fuse map/forEach stream steps into one
a9cfa63
@adolfopa
LPS-87864 Use stream to avoid holding the whole file list in memory
799f9f3 
File entries are heavy objects, so use a stream to avoid having to
generate/keep the whole list in memory.
@adolfopa
LPS-88194 Extend bulk capability with new property
c614053
@adolfopa
LPS-88194 Implement "select all"
71a5f68 
Users will be able to select all items in a folder, and apply an
operation to all of them.

Under the hood, this uses actionable dynamic queries, so it should be
reasonably efficient.
@adolfopa
LPS-88194 Check permissions
b3edfc7
@adolfopa
LPS-88194 Log exception and continue processing rest of entries
2d5dcca
@adolfopa
LPS-88194 Prepend "Bulk" to interface names
2b13bef
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering "ci:test:sf" and "ci:test:relevant" for this pull to run Source Formatter and relevant tests.

Comment "ci:test" to run the full PR Tester for this pull.

@adolfopa adolfopa mentioned this pull request Dec 12, 2018
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 1 second 460 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 17920c8d2d94e155e34b593a5389e49b8ae34e57

Sender Branch:

Branch Name: LPS-88194
Branch GIT ID: 2b13bef1edf2e295a1be3b8ee39a1217537034d3

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 75 out of 87 jobs passed in 2 hours 35 minutes 54 seconds 437 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d09f6374f3e822733acafe83cf931bcb0d9131c9

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 1f8eda285eb36a71d4b3be1bac19809eb9099740

75 out of 87 jobs PASSED

12 Failed Jobs:

75 Successful Jobs:
For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at 17920c8:
  4. ...

@brianchandotcom
Copy link
Owner

Merged. Thank you.
View total diff: 26af37e...3c6a98e

@brianchandotcom
Copy link
Owner

@adolfopa see minor changes in upstream. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
3 participants
@adolfopa @liferay-continuous-integration @brianchandotcom